Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Decoration sprites #151

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Added Decoration sprites #151

merged 4 commits into from
Jan 8, 2024

Conversation

OskarG0
Copy link
Collaborator

@OskarG0 OskarG0 commented Jan 8, 2024

changed sprites for water and added decorations to the gameboard

GameData::engine->MakeGameObject<Decoration>(
"waterGreen", atlas, 5, Vector2(), 2,
Rect(static_cast<float>(GameData::GridCells - 1), static_cast<float>(0),
GameData::CellSize, GameData::CellSize));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extract some of this into seperate methods to improve readability

added waves for the water
updated the water sprites and the treasure islands sprite
@OskarG0 OskarG0 requested a review from JoXW100 January 8, 2024 13:31
Copy link
Collaborator

@JoXW100 JoXW100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed the rebase error and am happy with the changes done to improve readability when creating the game board.

@OskarG0 OskarG0 merged commit 31af8d0 into main Jan 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants