Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #41

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Fix CI #41

merged 2 commits into from
Jul 2, 2024

Conversation

bquorning
Copy link
Contributor

CI's ubuntu-latest is running on an x86_64-linux platform. Since Gemfile.lock is committed, it needs to include this platform for CI to bundle successfully. Currently we get this error:

Your bundle only supports platforms ["arm64-darwin-22", "arm64-darwin-23"] but your local platform is x86_64-linux. Add the current platform to the lockfile with bundle lock --add-platform x86_64-linux and try again.

Also (if CI is green), you can add branch restrictions now.

bquorning added 2 commits July 2, 2024 16:37
CI's ubuntu-latest is running on an x86_64-linux platform. Since
Gemfile.lock is committed, it needs to include this platform for CI to
bundle successfully. Currently we get this error:

> Your bundle only supports platforms ["arm64-darwin-22",
> "arm64-darwin-23"] but your local platform is x86_64-linux.
> Add the current platform to the lockfile with
> `bundle lock --add-platform x86_64-linux` and try again.
@bquorning bquorning marked this pull request as ready for review July 2, 2024 14:45
@joeldrapper joeldrapper merged commit 2c63f35 into joeldrapper:main Jul 2, 2024
4 checks passed
@joeldrapper
Copy link
Owner

Do you think we should remove the lock file? 🤔

@bquorning bquorning deleted the fix-ci branch July 2, 2024 19:27
@bquorning
Copy link
Contributor Author

Do you think we should remove the lock file? 🤔

bundler.io says

This file is responsible for ensuring that every system this library is developed on has the exact same gems so it should always be checked into version control.

In repos where there’s no lockfile, I only miss it when I cannot figure out the combination of gem versions that will make the tests pass.

In repos where there is a lockfile, I get annoyed by the bundled gems always being outdated. And when we use Dependabot to update the gems, we get too many gem update pull requests. 😅

@bquorning
Copy link
Contributor Author

Case in point: Last passing ubuntu-latest 3.2 tests for Phlex vs first failing ubuntu-latest 3.2 tests for Phlex. This would be easier to debug if Gemfile.lock was checked in. And then perhaps add a separate job for using the edge version of qt (here’s an example from rubocop-rspec where we do something similar).

@joeldrapper
Copy link
Owner

Yeah, good point. Thanks for the Phlex PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants