Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add insecure flag for tls to otlp endpoint in collectors-config and SDKs #192

Open
emdneto opened this issue May 11, 2024 · 1 comment · May be fixed by #193
Open

Add insecure flag for tls to otlp endpoint in collectors-config and SDKs #192

emdneto opened this issue May 11, 2024 · 1 comment · May be fixed by #193
Assignees
@emdneto
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed priority:p3 Lowest priority level
Milestone
v0.2.0

Comments

@emdneto
Copy link
Contributor

emdneto commented May 11, 2024 •
edited
Loading

As a best practice, I think we should explicitly include the insecure flag in the TLS configuration for both otel-collector and recipe samples, even though some are set as default.

    tls:
      insecure: false

For example: here and here
@joaopgrassi
Copy link
Owner

Makes sense!

@joaopgrassi joaopgrassi added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers priority:p3 Lowest priority level labels May 12, 2024
@emdneto emdneto changed the title Add insecure flag to otlp endpoint in collectors-config and SDKs Add insecure flag in tls to otlp endpoint in collectors-config and SDKs May 12, 2024
@emdneto emdneto changed the title Add insecure flag in tls to otlp endpoint in collectors-config and SDKs Add insecure flag for tls to otlp endpoint in collectors-config and SDKs May 12, 2024
@emdneto emdneto linked a pull request May 12, 2024 that will close this issue
Draft
@joaopgrassi joaopgrassi moved this to In progress in v0.2.0 May 12, 2024
@joaopgrassi joaopgrassi added this to the v0.2.0 milestone May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emdneto emdneto

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed priority:p3 Lowest priority level
Projects
v0.2.0
Status: In progress
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

WIP: Add insecure flag to tls in otel-collector and SDKs emdneto/otel-recipes
2 participants
@joaopgrassi @emdneto