-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we add steps to run the collector? #188
Comments
That's a good point, the samples require a collector but it's never mentioned how to get that one running. Though I think we can solve that easily. We just need to add steps (probably first) to start the collector. One thing we don't have is a way to define an "inline" step - such that we could put the docker command and it would be displayed in the website. But that's also easy to fix. I will try to break this down since there's multiple tasks involved, then we can work on them in parallel. |
+1. This is great, but add in complications around how to configure the collector (Official otel docs are really long for what is essentially "how do I get to the point where I can instrument an app using the recipes" and sometimes only have proper documentation in the specification) |
In the mean-time, I figure y'all would know, does anyone have a good example of "MVP" collector config to get one of the metrics examples running? |
I think for most of recipes a simple Maybe we can think collector is also a dependency and define the version in recipefile.json to interpolate it in the command during rendering on the website. In cases we need custom collector config we can provide the config in a expandable code block so user can copy and run the command like this |
@jamesylgan inside each recipe you can find the collector config for that example. All of them will export via HTTP to our local "dummy" OTLP server but you get an idea on what to configure to change to any other otlp backend. |
This is not a bug issue at all, but I just noticed in all recipes we are using otel-collector to receive telemetry data and we don't mention it in any step. My concern is about if we should create reproducible steps user can follow to get same result we are providing on the recipe by just copying and paste.
So, the purpose of this issue is to discuss if we should also add steps to run the collector or not (maybe using docker). If so we can think in a way to improve that in each recipe.
The text was updated successfully, but these errors were encountered: