Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we add steps to run the collector? #188

Closed
emdneto opened this issue May 6, 2024 · 6 comments
Closed

Should we add steps to run the collector? #188

emdneto opened this issue May 6, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request feature-request priority:p1 Highest priority level triage:accepted
Milestone

Comments

@emdneto
Copy link
Contributor

emdneto commented May 6, 2024

This is not a bug issue at all, but I just noticed in all recipes we are using otel-collector to receive telemetry data and we don't mention it in any step. My concern is about if we should create reproducible steps user can follow to get same result we are providing on the recipe by just copying and paste.

So, the purpose of this issue is to discuss if we should also add steps to run the collector or not (maybe using docker). If so we can think in a way to improve that in each recipe.

@joaopgrassi
Copy link
Owner

joaopgrassi commented May 6, 2024

That's a good point, the samples require a collector but it's never mentioned how to get that one running.

Though I think we can solve that easily. We just need to add steps (probably first) to start the collector. One thing we don't have is a way to define an "inline" step - such that we could put the docker command and it would be displayed in the website. But that's also easy to fix.

I will try to break this down since there's multiple tasks involved, then we can work on them in parallel.

@jamesylgan
Copy link

+1. This is great, but add in complications around how to configure the collector (Official otel docs are really long for what is essentially "how do I get to the point where I can instrument an app using the recipes" and sometimes only have proper documentation in the specification)

@jamesylgan
Copy link

In the mean-time, I figure y'all would know, does anyone have a good example of "MVP" collector config to get one of the metrics examples running?

@emdneto
Copy link
Contributor Author

emdneto commented May 7, 2024

+1. This is great, but add in complications around how to configure the collector (Official otel docs are really long for what is essentially "how do I get to the point where I can instrument an app using the recipes" and sometimes only have proper documentation in the specification)

I think for most of recipes a simple docker run -p 4317:4317 otel/opentelemetry-collector-contrib:0.99.0 will work.

Maybe we can think collector is also a dependency and define the version in recipefile.json to interpolate it in the command during rendering on the website. In cases we need custom collector config we can provide the config in a expandable code block so user can copy and run the command like this docker run -v $(pwd)/config.yaml:/etc/otelcol-contrib/config.yaml -p 4317:4317 otel/opentelemetry-collector-contrib:0.99.0.

@joaopgrassi
Copy link
Owner

In the mean-time, I figure y'all would know, does anyone have a good example of "MVP" collector config to get one of the metrics examples running?

@jamesylgan inside each recipe you can find the collector config for that example. All of them will export via HTTP to our local "dummy" OTLP server but you get an idea on what to configure to change to any other otlp backend.

@joaopgrassi
Copy link
Owner

@emdneto thanks for reporting this!

I refined this a bit and opened a grouping issue #194. Closing this as triage accepted. Development should occur within that epic.

@github-project-automation github-project-automation bot moved this to Done in v0.2.0 May 12, 2024
@joaopgrassi joaopgrassi added this to the v0.2.0 milestone May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature-request priority:p1 Highest priority level triage:accepted
Projects
Status: Done
Development

No branches or pull requests

3 participants