Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the convert_rnnoise script #32

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

linkmauve
Copy link
Contributor

Instead of calling a function for every weight, do the modulo immediately while converting the data, and insert directly in the bytearray instead of allocating an intermediary list.

Instead of calling a function for every weight, do the modulo
immediately while converting the data, and insert directly in the
bytearray instead of allocating an intermediary list.
Copy link
Owner

@jneem jneem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jneem jneem merged commit 9a0fbbf into jneem:main Nov 9, 2024
1 check passed
@linkmauve linkmauve deleted the optimise-convert-rnnoise branch November 9, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants