On Demand Hashing #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cached writer used hash files to store the hashes of the generated files until now. While this may be a bit better for I/O since it only needs to read the hash files, and not all of the generated files, this is probably irrelevant for our use case.
After changing it, I realized why that has been the case so far: it didn't work anymore ;)
I took a bit more time to debug it this time and figured out that the hashes were generated before the tabwriter could work its magic. Therefore the freshly generated files had
\ts in there, and the files read from this had the tabs converted to spaces.I fixed it by generating the files through the tabwriter into a buffer and then comparing that buffer to the existing files.
Also there was a bug where the config was not passed by reference which broke the updated files report.