Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed unscaled to autoscaled, based on better nomenclature #9

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

dft-dutoit
Copy link
Collaborator

The UnScaledPESModel nomenclature was confusing, as in fact the class (as described in #8) is actually implementing automatically unit-normally distributing energies to improve NN learning performance.

This PR:

  • Renames the class UnScaledPESModel to AutoScaledPESModel
  • Renames all references to the class across graph-pes

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.99%. Comparing base (a89a2c2) to head (2d9a6ca).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   88.00%   87.99%   -0.02%     
==========================================
  Files          35       35              
  Lines        1968     1966       -2     
==========================================
- Hits         1732     1730       -2     
  Misses        236      236              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dft-dutoit dft-dutoit requested a review from jla-gardner July 11, 2024 10:14
Copy link
Owner

@jla-gardner jla-gardner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement - LGTM 👍

@dft-dutoit dft-dutoit merged commit 3cefdd0 into main Jul 11, 2024
5 of 6 checks passed
@dft-dutoit dft-dutoit deleted the fix-name-dftdt branch July 11, 2024 10:29
@jla-gardner jla-gardner mentioned this pull request Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants