Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated modules/rtc/MockClasses #2657

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

naman9271
Copy link

fixes #2637

Key Changes

  • Add Getters and Setters: Implement getters and setters for the properties in the MockPeerConnection and MockRTC classes.
  • Update createPeerConnection Method: Ensure it accepts parameters for id, usesUnifiedPlan, and simulcast.

@naman9271
Copy link
Author

@saghul, could you please review this? It introduces some breaking changes, so I’d appreciate it if you could verify that everything is working correctly and nothing is inadvertently broken.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

this.height = height;
}

/**
* Returns height.
* @returns {number}
*/
getSettings() {
getSettings(): { height: number } {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this return type is a number, but you are returning an object

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the previous implementation of getSettings() already returned an object, and my TypeScript migration keeps the same structure with proper typing. and for this i also create getter getHeight() as it is also returning the same thing as a number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrating modules/RTC Files To Typescript
3 participants