Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: convert to TS. #2641

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

ref: convert to TS. #2641

wants to merge 7 commits into from
+41 −32

Conversation

manzil-infinity180
Copy link

@manzil-infinity180 manzil-infinity180 commented Feb 14, 2025 •
edited
Loading

@manzil-infinity180
ref: convert to TS.
fdcaffb 
Signed-off-by: Rahul Vishwakarma <rahulvs2809@gmail.com>
@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@manzil-infinity180
AuthenticationEvents to TS
683f5d7 
Signed-off-by: Rahul Vishwakarma <rahulvs2809@gmail.com>
@manzil-infinity180
convert ts for service/RTC/Resolutions
92a6baf
@manzil-infinity180
ref: modules/util
15b1ffd 
Signed-off-by: Rahul Vishwakarma <rahulvs2809@gmail.com>
@manzil-infinity180
Copy link
Author

@saghul please review !!!

saghul
saghul reviewed Feb 17, 2025
View reviewed changes
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this started! I leeft a comment and noticed some style issue the linter will tell you about.

@manzil-infinity180
Copy link
Author

d13ee37 possibly this will fix it !!

@saghul could you please run the test

@saghul
Copy link
Member

saghul commented Feb 20, 2025

You need to adjust the export so the tests can pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saghul saghul Awaiting requested review from saghul

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manzil-infinity180 @jitsi-jenkins @saghul