Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not send presence unavailable after a failure. #192

Merged

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Nov 6, 2023

Attempts to address jitsi/jitsi-videobridge#2052 by not sending presence
unavailable when disconnecting due to a connection failure. If the TCP
connection is alive then the server will notice that it's closed. If it
isn't alive then it won't matter anyway.

Attempts to address jitsi/jitsi-videobridge#2052 by not sending presence
unavailable when disconnecting due to a connection failure. If the TCP
connection is alive then the server will notice that it's closed. If it
isn't alive then it won't matter anyway.
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #192 (69dcf0d) into master (f49982f) will decrease coverage by 0.07%.
Report is 1 commits behind head on master.
The diff coverage is 6.89%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #192      +/-   ##
============================================
- Coverage     24.05%   23.98%   -0.07%     
  Complexity      126      126              
============================================
  Files            32       32              
  Lines          1135     1138       +3     
  Branches        102      102              
============================================
  Hits            273      273              
- Misses          844      847       +3     
  Partials         18       18              
Files Coverage Δ
...ain/kotlin/org/jitsi/config/ConfigSourceWrapper.kt 0.00% <0.00%> (ø)
...ig/src/main/kotlin/org/jitsi/config/JitsiConfig.kt 0.00% <0.00%> (ø)
.../main/java/org/jitsi/xmpp/mucclient/MucClient.java 0.00% <0.00%> (ø)
...tsi/config/AbstractReadOnlyConfigurationService.kt 25.58% <11.11%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bebfb15...69dcf0d. Read the comment docs.

@bgrozev bgrozev merged commit 23ac61c into jitsi:master Nov 7, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants