Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace templating engine #8

Merged
merged 11 commits into from
Feb 19, 2024
Merged

Replace templating engine #8

merged 11 commits into from
Feb 19, 2024

Conversation

jippi
Copy link
Owner

@jippi jippi commented Feb 18, 2024

No description provided.

@jippi jippi self-assigned this Feb 18, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 129 lines in your changes are missing coverage. Please review.

Comparison is base (39d4b31) 59.66% compared to head (5df1e41) 64.63%.

Files Patch % Lines
cmd/update/update.go 5.40% 35 Missing ⚠️
pkg/validation/explain.go 44.18% 23 Missing and 1 partial ⚠️
pkg/ast/document.go 78.66% 14 Missing and 2 partials ⚠️
pkg/template/template.go 83.69% 13 Missing and 2 partials ⚠️
cmd/validate/validate.go 0.00% 14 Missing ⚠️
pkg/cli/shared/complete.go 25.00% 6 Missing ⚠️
pkg/render/render.go 64.28% 5 Missing ⚠️
pkg/ast/assignment_selectors.go 33.33% 4 Missing ⚠️
pkg/ast/upsert/option.go 55.55% 4 Missing ⚠️
pkg/template/errors.go 0.00% 1 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   59.66%   64.63%   +4.96%     
==========================================
  Files          58       56       -2     
  Lines        2871     2768     -103     
==========================================
+ Hits         1713     1789      +76     
+ Misses       1069      887     -182     
- Partials       89       92       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jippi jippi marked this pull request as ready for review February 19, 2024 00:34
@jippi jippi merged commit 6237882 into main Feb 19, 2024
10 checks passed
@jippi jippi deleted the rework-template-v2 branch February 19, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant