Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and testing #7

Merged
merged 33 commits into from
Feb 15, 2024
Merged

Refactoring and testing #7

merged 33 commits into from
Feb 15, 2024

Conversation

jippi
Copy link
Owner

@jippi jippi commented Feb 15, 2024

  • simplified tui package
  • refactored most internals to be more resilient and testable
  • greatly expanded test coverage
  • aligned naming of various types across the codebase

@jippi jippi self-assigned this Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 161 lines in your changes are missing coverage. Please review.

Comparison is base (28a0848) 48.17% compared to head (25a2079) 58.93%.

Files Patch % Lines
cmd/validate/validate.go 3.84% 25 Missing ⚠️
cmd/update/update.go 4.16% 23 Missing ⚠️
pkg/validation/explain.go 28.12% 23 Missing ⚠️
pkg/tui/printer.go 67.30% 17 Missing ⚠️
pkg/render/output_colorized.go 0.00% 13 Missing ⚠️
cmd/value/value.go 7.69% 12 Missing ⚠️
pkg/ast/document.go 45.00% 9 Missing and 2 partials ⚠️
pkg/ast/upsert/upsert.go 77.77% 4 Missing and 2 partials ⚠️
pkg/tui/theme.go 81.81% 5 Missing and 1 partial ⚠️
cmd/fmt/fmt.go 16.66% 5 Missing ⚠️
... and 8 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main       #7       +/-   ##
===========================================
+ Coverage   48.17%   58.93%   +10.76%     
===========================================
  Files          57       58        +1     
  Lines        2761     2849       +88     
===========================================
+ Hits         1330     1679      +349     
+ Misses       1370     1080      -290     
- Partials       61       90       +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jippi jippi merged commit 4d85ee1 into main Feb 15, 2024
10 checks passed
@jippi jippi deleted the tui.rework branch February 15, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant