✅ Fixed bug with season endpoint returning incorrect items when continuing flag specified #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irfan-dahir
reviewed
Nov 7, 2024
irfan-dahir
approved these changes
Nov 8, 2024
irfan-dahir
approved these changes
Nov 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #557 +/- ##
============================================
- Coverage 57.86% 57.24% -0.62%
- Complexity 1361 1391 +30
============================================
Files 339 340 +1
Lines 5273 5669 +396
============================================
+ Hits 3051 3245 +194
- Misses 2222 2424 +202 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #555
The filter predicate for mongodb was incorrect, it included also those items when
continuingfilter flag was present which are from the same month as the month of the$fromdate calculated based on the season endpoint request.This PR fixes that issue, also added a test to validate it.