Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing geocode function is unusable #1

Open
sshikov opened this issue May 24, 2017 · 5 comments
Open

Existing geocode function is unusable #1

sshikov opened this issue May 24, 2017 · 5 comments

Comments

@sshikov
Copy link

sshikov commented May 24, 2017

Geocoder shoud be able to process multiple results of address->coordinates geocoding, filter candidates by address type, location type, order by some quality criteria.

Filtering and sorting should be customizable.

It will be freat if geocode provider will be also customizable, i.e. not Google Maps only, but OpenStreetMap, Yandex, etc, etc.

@jifalops
Copy link
Owner

It currently only handles one operation at a time by design. Processing of aggregate results is highly dependent on end users' needs and isn't something I plan on implementing at this time.

Being compatible with other providers is something I need to look into. Do you know if the APIs are similar?

@sshikov
Copy link
Author

sshikov commented May 24, 2017

You can just add one or two functions for results processing, like existing onComplete.

@sshikov
Copy link
Author

sshikov commented May 24, 2017

I know about yandex maps geocoding API in detail, and about Esri (ArcGIS). They are all similar to each other.

@sshikov
Copy link
Author

sshikov commented May 24, 2017

Only difference in general is returned JSON structure - i.e. object and field names.

@sshikov
Copy link
Author

sshikov commented May 24, 2017

Just for example: to geocode street address, we can ask google/arcgis/yandex/openstreetmap, filter results by quality (remove results like city/region, not street with buiding number), order by quality, and if we still have more that 1 result, return 1st one - as you have implemented right now.

If you don't do filtering at all - list of candidates could be used to show suggestions. I.e. this is just another use case for the same code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants