rename suffix from dylib to so on macOS. fix #2

jiacai2050 · Apr 23, 2022 · 282423b · 282423b
1 parent 443701b
commit 282423b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -21,8 +21,8 @@ jobs:
           #   artifact_name: emacs/omg-dyn.dll
           #   asset_name: omg-dyn.dll
           - os: macos-latest
-            artifact_name: emacs/omg-dyn.dylib
-            asset_name: macos-x86-64-omg-dyn.dylib
+            artifact_name: emacs/omg-dyn.so
+            asset_name: macos-x86-64-omg-dyn.so
 
     steps:
     - uses: actions/checkout@v2

diff --git a/Makefile b/Makefile
@@ -8,13 +8,11 @@ else
 	uname_S := $(shell uname -s)
 endif
 
+# On macOS, dynamic modules can also have the suffix .so in addition to .dylib.
 SO_FILE = $(EMACS_DIR)/omg-dyn.so
 ifeq ($(uname_S), Windows)
 	SO_FILE = $(EMACS_DIR)/omg-dyn.dll
 endif
-ifeq ($(uname_S), Darwin)
-	SO_FILE = $(EMACS_DIR)/omg-dyn.dylib
-endif
 
 CLI = omg-cli
 OBJECTS = $(CORE_DIR)/omg.o $(CLI_DIR)/cli.o $(EMACS_DIR)/emacs.o