[BE4] 장세계 #19
Open
[BE4] 장세계 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farrar142
reviewed
Jan 7, 2025
Comment on lines
+30
to
+50
| private LocalDateTime createDate; | ||
|
|
||
| @OneToMany(mappedBy = "question", cascade = CascadeType.REMOVE) | ||
| private List<Answer> answerList; | ||
|
|
||
| @ManyToOne | ||
| private SiteUser author; | ||
|
|
||
| private LocalDateTime modifyDate; | ||
|
|
||
| @ManyToMany | ||
| Set<SiteUser> voter; // set은 중복데이터 불가 | ||
|
|
||
| @OneToMany(mappedBy = "question", cascade = CascadeType.REMOVE) | ||
| private List<Comment> commentList; | ||
|
|
||
| @ManyToOne | ||
| private Category category; | ||
|
|
||
| @Column(columnDefinition = "integer default 0", nullable = false) | ||
| private int view; |
There was a problem hiding this comment.
상위 엔티티에 대한 필드, 날짜에 대한 필드, 자식들에 대한 필드는 서로 관련있는 것끼리 정렬되면 더 보기 좋겠습니다.
farrar142
reviewed
Jan 7, 2025
Comment on lines
+54
to
+58
| if (question.isPresent()) { | ||
| return question.get(); | ||
| } else{ | ||
| throw new DataNotFoundException("question not found"); | ||
| } |
There was a problem hiding this comment.
옵셔널을 if로 체크하는 부분이 많이 보이는데 orElseThrow나 orElseGet으로 처리하면 더 깔끔해 보일 것 같습니다.
farrar142
reviewed
Jan 7, 2025
Comment on lines
+100
to
+103
| public void plusView(Question question) { | ||
| question.setView(question.getView() + 1); | ||
| this.questionRepository.save(question); | ||
| } |
There was a problem hiding this comment.
plus라는 네이밍이 완전 틀린것은 아니지만 add나 increase 처럼 동사로 시작하는 편이 좋을 것 같습니다
|
전체적으로 잘해주셨고, main패키지안에 main이 중복으로 들어가있네요, 파일 정리가 필요해보입니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr이 close 되어 다시올립니다!