[BE4] 황인우 #16
Open
[BE4] 황인우 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farrar142
reviewed
Jan 3, 2025
Comment on lines
+11
to
+29
| public static void permission(Object object, String username, HttpMethod httpMethod) { | ||
| SiteUser author; | ||
|
|
||
| if(object instanceof Question) { | ||
| Question question = (Question) object; | ||
| author = question.getAuthor(); | ||
| } else if(object instanceof Answer) { | ||
| Answer answer = (Answer) object; | ||
| author = answer.getAuthor(); | ||
| } else if(object instanceof Comment) { | ||
| Comment comment = (Comment) object; | ||
| author = comment.getAuthor(); | ||
| } else { | ||
| throw new IllegalArgumentException("잘못된 데이터 타입입니다."); | ||
| } | ||
|
|
||
| if(!author.getUsername().equals(username)){ | ||
| throw new ResponseStatusException(HttpStatus.BAD_REQUEST, "%s권한이 없습니다.".formatted(httpMethod.getValue())); | ||
| } |
There was a problem hiding this comment.
Object대신 BaseEntity타입을 받았다면 당장은 간결한 코드로 만들 수 있었을 것 같은데, 확장성을 위해서인가요?
farrar142
reviewed
Jan 3, 2025
Comment on lines
+14
to
+16
| private Integer questionId; | ||
|
|
||
| private Integer parentId; |
farrar142
reviewed
Jan 3, 2025
Comment on lines
+19
to
+27
| private String content; | ||
|
|
||
| private LocalDateTime createDate; | ||
|
|
||
| @ManyToOne | ||
| private SiteUser author; | ||
|
|
||
| private LocalDateTime modifyDate; | ||
| } |
There was a problem hiding this comment.
변수를 관련있는 순으로 정렬 하는 걸 추천드립니다. ex) author, content, createDate, modifyDate순
farrar142
reviewed
Jan 3, 2025
|
|
||
| // 임시 비밀번호 발송 | ||
| System.out.println("임시 비밀번호 생성 : " + tempPassword); | ||
| this.emailService.sendTempPassword(user.getEmail(), tempPassword); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
새로운 기능 구현 커밋 전에 기본 상태를 한번 커밋 해놓으면 변경 상태를 확인하기 더 좋겠네요..! 다음부턴 그렇게 해야겠습니다ㅎㅎㅎ