Angular: Quick Filter buttons are not generated anymore

[OmarHawk]

Overview of the issue

Until at least version 8.1.0, buttons for filtering the other side of the entity were generated (initial feature: #18370). This is at least in 8.5.0 not the case anymore, as the corresponding relationships are already filtered out beforehand, so the links are not generated anymore.

Motivation for or Use Case

Feature worked before and kind of all of the of the code for that is still in there.

Reproduce the error

1. Have an application with a ManyToOne / OneToMany /ManyToMany relationship using Angular as frontend.
2. Generate application
3. Expect buttons in the list view pointing from one Entity to the filtered list of the other. (see Display a link to a filtered view for the Many Side of a OneToMany / ManyToOne relationship on the One side #18370)
4. Miss out these buttons

Related issues

Changes in #25140 are causing this, I think. Previously, the list of relationships passed to the client generator were unfiltered apart from the skipClient flag.

Suggest a Fix

get rid of the persistable/eagerload filtering here. Don't know, what effect this has elsewhere, should be tested - or only be changed for the Angular client in doubt:

generator-jhipster/generators/client/support/filter-entities.ts

Lines 25 to 29 in eee53c5

	export const filterEntityPropertiesForClient = (entity: Entity): Entity => ({
	...entity,
	fields: entity.fields.filter(field => !field.skipClient),
	relationships: entity.relationships.filter(rel => !rel.skipClient && (rel.persistableRelationship || rel.relationshipEagerLoad)),
	});

by the way, the parts in the html of the Angular client are still there though and there you can also see the the contradictionary conditions:

generator-jhipster/generators/angular/templates/src/main/webapp/app/entities/_entityFolder_/list/_entityFile_.component.html.ejs

Lines 178 to 191 in eee53c5

	<%_ for (const relationship of relationships.filter(rel => !rel.otherEntityIsEmbedded)) { _%>
	<%_ if (relationship.otherEntity.jpaMetamodelFiltering && relationship.otherEntity.paginationPagination && relationship.collection && !relationship.persistableRelationship) {
	const otherEntityTranslationKey = i18nKeyPrefix + '.' + relationship.relationshipName;
	_%>
	<button type="submit"
	[routerLink]="['/<%= relationship.otherEntity.entityPage %>']"
	[queryParams]="{ 'filter[<%= relationship.otherEntityRelationshipName %>Id.in]': <%= entityInstance %>.<%= primaryKey.name %> }"
	class="btn btn-info btn-sm"
	data-cy="filterOtherEntityButton">
	<fa-icon icon="eye"></fa-icon>
	<span class="d-none d-md-inline">__jhiTranslateTagPipe__('entity.action.show', { "otherEntity": "<%= otherEntityTranslationKey %>" })</span>
	</button>
	<%_ } _%>
	<%_ } _%>

&& !persistableRelationship (Angular code) vs. persistableRelationship (filter-entities.ts)

JHipster Version(s)

8.5.0

JHipster configuration

Entity configuration(s) entityName.json files generated in the .jhipster directory

Browsers and Operating System

• Checking this box is mandatory (this is just to show you read everything)

[OmarHawk]

I've tried my suggestion locally against my application and it indeed does fix this particular part of the generation.