Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Spring Boot's Docker Compose support #24469

Closed
mraible opened this issue Dec 5, 2023 · 10 comments · Fixed by #27062
Closed

Integrate Spring Boot's Docker Compose support #24469

mraible opened this issue Dec 5, 2023 · 10 comments · Fixed by #27062
Assignees
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: docker 🐳 $500 https://www.jhipster.tech/bug-bounties/
Milestone

Comments

@mraible
Copy link
Contributor

mraible commented Dec 5, 2023

Overview of the issue

Add Docker Compose support so dependent containers are started automatically. At the bottom of the docs, it mentions how you can point to a file. It'd be cool if multiple files are allowed.

Motivation for or Use Case

This is a better developer experience because you do t have to start anything manually. It might help simplify our CI jobs too.

JHipster Version(s)

8.0.0

@shwetarkadam
Copy link

Hello would like to work on this .Possible to assign me this ?

@DanielFran
Copy link
Member

Hello would like to work on this .Possible to assign me this ?

Go head😉

@mshima
Copy link
Member

mshima commented Aug 24, 2024

@shwetarkadam have you worked on this?

@mshima
Copy link
Member

mshima commented Aug 24, 2024

Database not started is the most common error: #27003, #27053, #26375.
I am testing how this integration works and seems to work to avoid this error.

We will probably need to add daily-builds tests.

@mraible mraible added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $300 https://www.jhipster.tech/bug-bounties/ labels Aug 27, 2024
@mraible mraible mentioned this issue Aug 27, 2024
6 tasks
@mraible mraible added this to the 8.7.1 milestone Aug 28, 2024
@mshima
Copy link
Member

mshima commented Sep 7, 2024

Test plan requires to test every container:

  • PostgreSQL, MariaDB, MySQL and h2 in imperative and reactive variants.
  • Cassandra, MongoDB, Neo4J in imperative, may require reactive tests.
  • Kafka, Redis.

@DanielFran DanielFran added $500 https://www.jhipster.tech/bug-bounties/ and removed $300 https://www.jhipster.tech/bug-bounties/ labels Sep 13, 2024
@DanielFran
Copy link
Member

Increasing bug bounty since it requires lot of work

@mshima
Copy link
Member

mshima commented Sep 17, 2024

@DanielFran
Copy link
Member

@mshima approved

@vishal423
Copy link
Contributor

After this change, it seems docker is must to run generated applications with a dev profile (even though generated applications don't require that). I believe we should highlight this prerequisite and also suggest a way to disable it when not needed via property spring.docker.compose.enabled=false

@mshima
Copy link
Member

mshima commented Sep 23, 2024

After this change, it seems docker is must to run generated applications with a dev profile (even though generated applications don't require that). I believe we should highlight this prerequisite and also suggest a way to disable it when not needed via property spring.docker.compose.enabled=false

#27380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: docker 🐳 $500 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants