New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check openness before merging PRs #20

Open

jonaslindmark opened this issue May 6, 2015 · 0 comments

Labels

bug

jonaslindmark commented May 6, 2015

So I accidently merged a PR just now by doing this:

"prepare" a comment but don't comment
Click "Close and comment"
Click delete branch
Tutter merged your commit

In general I think the expected behavior is that if the PR is closed you can't merge it.

jhaals added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment