From 49e8d99315ac04fcd117703531033a8aebe29ea0 Mon Sep 17 00:00:00 2001
From: Austin Turner <paustint@gmail.com>
Date: Sun, 10 Mar 2024 09:52:18 -0700
Subject: [PATCH] Fix currency length/precision issue

scale+precision did not behave the same way as the salesforce UI leading to user confusion.

This has been corrected, the ui now sets precision the same way as the Salesforce UI `precision = scale+precision`

resolves #764
---
 .../create-fields/create-fields-utils.tsx       | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/apps/jetstream/src/app/components/shared/create-fields/create-fields-utils.tsx b/apps/jetstream/src/app/components/shared/create-fields/create-fields-utils.tsx
index 1aa81f89d..779daed47 100644
--- a/apps/jetstream/src/app/components/shared/create-fields/create-fields-utils.tsx
+++ b/apps/jetstream/src/app/components/shared/create-fields/create-fields-utils.tsx
@@ -172,12 +172,13 @@ export const fieldDefinitions: FieldDefinitions = {
   precision: {
     label: 'Length',
     type: 'text', // number
+    labelHelp: 'Number of digits to the left of the decimal point',
     validate: (value: string) => {
       if (!value || !/^[0-9]+$/.test(value)) {
         return false;
       }
       const numValue = Number(value);
-      return isFinite(numValue) && numValue >= 0 && numValue <= 18;
+      return isFinite(numValue) && numValue >= 1 && numValue <= 18;
     },
     invalidErrorMessage: 'Must be between 0 and 18',
     required: true,
@@ -185,14 +186,15 @@ export const fieldDefinitions: FieldDefinitions = {
   scale: {
     label: 'Decimal Places',
     type: 'text',
+    labelHelp: 'Number of digits to the right of the decimal point',
     validate: (value: string) => {
       if (!value || !/^[0-9]+$/.test(value)) {
         return false;
       }
       const numValue = Number(value);
-      return isFinite(numValue) && numValue >= 0 && numValue <= 18;
+      return isFinite(numValue) && numValue >= 0 && numValue <= 17;
     },
-    invalidErrorMessage: 'Must be between 0 and 18',
+    invalidErrorMessage: 'Must be between 0 and 17',
     required: true,
   },
   required: {
@@ -819,6 +821,15 @@ function prepareFieldPayload(sobject: string, fieldValues: FieldValues, orgNames
   const fieldApiName = orgNamespace ? `${orgNamespace}__${fieldMetadata.fullName}__c` : `${fieldMetadata.fullName}__c`;
   fieldMetadata.fullName = `${sobject}.${fieldApiName}`;
 
+  if (fieldMetadata.scale && fieldMetadata.precision) {
+    const scale = Number(fieldMetadata.scale);
+    const precision = Number(fieldMetadata.precision);
+    if (!Number.isNaN(scale) && !Number.isNaN(precision)) {
+      fieldMetadata.scale = scale;
+      fieldMetadata.precision = scale + precision;
+    }
+  }
+
   if (fieldValues.type.value === 'Formula') {
     fieldMetadata.type = fieldValues.secondaryType.value;
     fieldMetadata.secondaryType = undefined;