Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check if Discogs release matches local release #5

Open
timpulver opened this issue Apr 4, 2013 · 3 comments
Open

Add check if Discogs release matches local release #5

timpulver opened this issue Apr 4, 2013 · 3 comments
Assignees

Comments

@timpulver
Copy link

Would be great to have the possibility to perform a check if the Discogs release and the local release do match. For example if one track is missing on the local release, all tracks will be written wrong without a check.

@ghost ghost assigned jesseward Apr 5, 2013
@triplem
Copy link
Contributor

triplem commented Jul 10, 2013

A check for the right number of tracks is already implemented. Are there more checks, which should be implemented?

@jesseward
Copy link
Owner

right now the check is very limited.

if the number of tracks matches the number returned by the discogs api, then we assume all is well. Right now tracks are sorted then matched alphabetically. In addition to a simple count, we should add basic string comparison to ensure there at-least X amount of similarity between source track name and the returned discogs track name.

python's difflib or a wrapper around difflib such as https://github.com/seatgeek/fuzzywuzzy would do the trick.

@timpulver
Copy link
Author

Beets compares some values and returns the similarities in percent. I think this solution is quite nice. You could add a threshold parameter, like »everything beyond 70% similarity is okay«. Here is the relevant beets source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants