Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spike rule error with no data in cur time window; Add ability to copy rule params into match data #1605

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

jertel
Copy link
Owner

@jertel jertel commented Jan 18, 2025

Description

Two changes:

  1. Fixes a Spike Rule issue identified in Comparing values percentually #1600 where the rule will crash if the current time window has no match data.
  2. Add new feature that provide ability to copy rule params (name, etc) into the match data. This should eliminate the need for many user Enhancements that want to show rule parameter data in alert notifications.

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@nsano-rururu
Copy link
Collaborator

Do I need to set additional parameters in schema.yaml?

@jertel
Copy link
Owner Author

jertel commented Jan 18, 2025

Yes, thank you for the reminder.

@nsano-rururu nsano-rururu merged commit 667be2b into master Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants