-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(quickwit): add quickwit integration #1409
Conversation
eb0fc20
to
ba63753
Compare
This sounds great! I'm looking forward to trying it out. |
e4e78ce
to
39995fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is a work in progress, but I figured I'd review it as you go to help me follow along.
22e765f
to
5d34955
Compare
No problem at all. I'm still figuring out if it's really compliant or not. For example with real test, I have this: qw_tests-elastalert-1 | ERROR:elastalert:Error finding recent pending alerts: RequestError(400, '{\n "message": "OneOrMany could not deserialize any variant:\\n One: unknown field `from`, expected one of `gt`, `gte`, `lt`, `lte`, `boost`\\n Many: invalid type: map, expected a sequence at line 1 column 206"\n}') {'query': {'bool': {'must': {'query_string': {'query': '!_exists_:aggregate_id AND alert_sent:false'}}, 'filter': {'range': {'alert_time': {'from': '2024-03-26T17:09:24.709242Z', 'to': '2024-03-28T17:09:24.709947Z'}}}}}, 'sort': {'alert_time': {'order': 'asc'}}} Maybe @fmassot can help to see if it's something we can fix on quickwit side or not. For the rest, I'll take care of all your feedbacks, thanks for thoses. |
5d34955
to
f2e3e31
Compare
Signed-off-by: Idriss Neumann <idriss.neumann@comwork.io>
f2e3e31
to
7cfbb09
Compare
c65be30
to
f6a029f
Compare
…call some non-elastic endpoints + multiple fixes Signed-off-by: Idriss Neumann <idriss.neumann@comwork.io>
f6a029f
to
9f08939
Compare
This PR is stale because it has been open for 30 days with no activity. The longer a PR remains stale the more out of date with the main branch it becomes. |
This PR was closed because it has been inactive for 30 days since being marked as stale. It will be automatically locked after an additional 30 days. If there is still a commitment to finishing this PR please re-open it, or request that a project maintainer re-open it before it becomes locked. |
@idrissneumann may I know if this is already completed or anything left? I really want to use quickwit but currently we are actively using elastalert to manage log based alert. anyway, love your work! |
Description
Hi. For now it's still draft but I'm exploring how elastalert2 can comply with Quickwit.
To provide a bit of context:
elastalert
several years ago and even rebuild version for ARM32, I'm pretty convinced that it's still a relevant tool for alerting used as an external microservice/api/v1/_elastic
suffix to the URL, etcChecklist
make test-docker
with my changes.Questions or Comments