Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix collision of rule option #1408

Merged
merged 3 commits into from
Mar 28, 2024
Merged

fix collision of rule option #1408

merged 3 commits into from
Mar 28, 2024

Conversation

jertel
Copy link
Owner

@jertel jertel commented Mar 27, 2024 •
edited
Loading

Description

Fixes issue identified in #1397 caused by PR #1193

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@jertel jertel requested a review from nsano-rururu March 28, 2024 12:20
@nsano-rururu nsano-rururu merged commit 0a3fcb8 into master Mar 28, 2024
1 check passed
@jertel jertel deleted the jertel/fix1193 branch March 28, 2024 15:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nsano-rururu nsano-rururu nsano-rururu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jertel @nsano-rururu