add virtual gateway to logical interface #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add virtual_gateway* for ipv4 * chore: change var name to tidy things up * chore: disable linter for interfaceLogicalBlockFamilyInetBlockAddress Either the tags are lined up, or the line is short enough. I´ve chosen tags * chore: update docs * chore: make linter happy --------- Co-authored-by: Jeremy Muriel <jeremy@jeremm.fr>
- fix missing attributes in data-source - add virtual_gateway_v4|6_mac arguments - add virtual_gateway_address in family_inet6 - add config validator to test with name of interface (irb prefix) - fix arguments order and rename field to follow the usual format - add test data to acceptance tests - fix documentation format with arguments description under the name - split vrrp_group block config set/read in dedicated function
interface during Plan instead of during Apply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENHANCEMENTS:
virtual_gateway_accept_data,virtual_gateway_v4_macandvirtual_gateway_v6_macargumentsvirtual_gateway_addressargument inaddressblock infamily_inetandfamily_inet6blocksvirtual_gateway_accept_data,virtual_gateway_v4_mac,virtual_gateway_v6_macandvirtual_gateway_addressattributes like resource