Merge pull request #640 from jeremmfr/main

Release v2.6.0

.github/workflows/go.yml

@@ -1,14 +1,14 @@
 name: Go Tests
 on: [push, pull_request]
 jobs:
-  build-1_20:
-    name: Build 1.20
+  build-1_21:
+    name: Build 1.21
     runs-on: ubuntu-latest
     steps:
-      - name: Set up Go 1.20
+      - name: Set up Go 1.21
         uses: actions/setup-go@v5
         with:
-          go-version: '1.20'
+          go-version: '1.21'
           check-latest: true
         id: go
       - name: Disable cgo
@@ -21,14 +21,14 @@ jobs:
       - name: Build
         run: go build -v .
 
-  build-1_21:
-    name: Build 1.21
+  build-1_22:
+    name: Build 1.22
     runs-on: ubuntu-latest
     steps:
-      - name: Set up Go 1.21
+      - name: Set up Go 1.22
         uses: actions/setup-go@v5
         with:
-          go-version: '1.21'
+          go-version: '1.22'
           check-latest: true
         id: go
       - name: Disable cgo
@@ -45,10 +45,10 @@ jobs:
     name: Test
     runs-on: ubuntu-latest
     steps:
-      - name: Set up Go 1.21
+      - name: Set up Go 1.22
         uses: actions/setup-go@v5
         with:
-          go-version: '1.21'
+          go-version: '1.22'
           check-latest: true
         id: go
       - name: Disable cgo

.github/workflows/go_analysis.yml

@@ -16,7 +16,7 @@ jobs:
       - name: Running govulncheck
         uses: Templum/govulncheck-action@v1.0.0
         with:
-          go-version: '1.21'
+          go-version: '1.22'
           package: ./...
           fail-on-vuln: false
 
@@ -29,6 +29,10 @@ jobs:
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
+      - name: Set up Go
+        uses: actions/setup-go@v5
+        with:
+          go-version-file: go.mod
       - name: Initialize CodeQL
         uses: github/codeql-action/init@v3
         with:

.github/workflows/linters.yml

@@ -5,10 +5,10 @@ jobs:
     name: golangci-lint
     runs-on: ubuntu-latest
     steps:
-      - name: Set up Go 1.21
+      - name: Set up Go 1.22
         uses: actions/setup-go@v5
         with:
-          go-version: '1.21'
+          go-version: '1.22'
           check-latest: true
         id: go
       - name: Disable cgo
@@ -17,9 +17,9 @@ jobs:
       - name: Check out code
         uses: actions/checkout@v4
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v4
         with:
-          version: 'v1.55.2'
+          version: 'v1.56.1'
           args: -c .golangci.yml -v
 
   markdown-lint:
@@ -38,10 +38,10 @@ jobs:
     name: terrafmt
     runs-on: ubuntu-latest
     steps:
-      - name: Set up Go 1.21
+      - name: Set up Go 1.22
         uses: actions/setup-go@v5
         with:
-          go-version: '1.21'
+          go-version: '1.22'
           check-latest: true
         id: go
       - name: Show version

.github/workflows/releases.yml

@@ -38,10 +38,10 @@ jobs:
           - goos: windows
             goarch: arm64
     steps:
-      - name: Set up Go 1.21
+      - name: Set up Go 1.22
         uses: actions/setup-go@v5
         with:
-          go-version: '1.21'
+          go-version: '1.22'
           check-latest: true
         id: go
       - name: Show version

.golangci.yml

@@ -32,6 +32,7 @@ linters:
     - depguard
     - gosec
     - inamedparam
+    - ireturn
 linters-settings:
   gci:
     custom-order: true
@@ -64,15 +65,6 @@ issues:
     - text: "github.com/jeremmfr/terraform-provider-junos/internal"
       linters:
         - wrapcheck
-    - text: "github.com/hashicorp/terraform-plugin-framework/provider"
-      linters:
-        - ireturn
-    - text: "github.com/hashicorp/terraform-plugin-framework/resource"
-      linters:
-        - ireturn
-    - text: "github.com/hashicorp/terraform-plugin-framework/datasource"
-      linters:
-        - ireturn
     - path: "internal/providersdk/"
       linters:
         - goconst

CHANGELOG.md

@@ -1,6 +1,56 @@
 <!-- markdownlint-disable-file MD013 MD041 -->
 # changelog
 
+## v2.6.0 (2024-03-13)
+
+FEATURES:
+
+* add **junos_system_tacplus_server** resource (Fix [#629](https://github.com/jeremmfr/terraform-provider-junos/issues/629))
+* add **junos_virtual_chassis** resource (Fix [#623](https://github.com/jeremmfr/terraform-provider-junos/issues/623))
+
+ENHANCEMENTS:
+
+* **resource/junos_eventoptions_destination**: resource now use new [terraform-plugin-framework](https://github.com/hashicorp/terraform-plugin-framework)  
+  optional string attributes doesn't accept *empty* value  
+* **resource/junos_eventoptions_generate_event**:
+  * resource now use new [terraform-plugin-framework](https://github.com/hashicorp/terraform-plugin-framework)  
+    optional boolean attributes doesn't accept value *false*  
+  * add `start_time` argument
+* **resource/junos_eventoptions_policy**: resource now use new [terraform-plugin-framework](https://github.com/hashicorp/terraform-plugin-framework)  
+  some of config errors are now sent during Plan instead of during Apply  
+  optional boolean attributes doesn't accept value *false*  
+  optional string attributes doesn't accept *empty* value  
+  the resource schema has been upgraded to have one-blocks in single mode instead of list
+* **resource/junos_snmp**: resource now use new [terraform-plugin-framework](https://github.com/hashicorp/terraform-plugin-framework)  
+  optional boolean attributes doesn't accept value *false*  
+  optional string attributes doesn't accept *empty* value  
+  the resource schema has been upgraded to have one-blocks in single mode instead of list
+* **resource/junos_snmp_clientlist**: resource now use new [terraform-plugin-framework](https://github.com/hashicorp/terraform-plugin-framework)
+* **resource/junos_snmp_community**: resource now use new [terraform-plugin-framework](https://github.com/hashicorp/terraform-plugin-framework)  
+  some of config errors are now sent during Plan instead of during Apply  
+  optional boolean attributes doesn't accept value *false*  
+  optional string attributes doesn't accept *empty* value  
+* **resource/junos_snmp_v3_community**: resource now use new [terraform-plugin-framework](https://github.com/hashicorp/terraform-plugin-framework)  
+  optional string attributes doesn't accept *empty* value  
+* **resource/junos_snmp_v3_usm_user**:  
+  * resource now use new [terraform-plugin-framework](https://github.com/hashicorp/terraform-plugin-framework)  
+  some of config errors are now sent during Plan instead of during Apply  
+  optional string attributes doesn't accept *empty* value  
+  * `authentication_type` argument accept new value: `authentication-sha224`, `authentication-sha256`, `authentication-sha384` and `authentication-sha512`
+* **resource/junos_snmp_v3_vacm_accessgroup**: resource now use new [terraform-plugin-framework](https://github.com/hashicorp/terraform-plugin-framework)  
+  some of config errors are now sent during Plan instead of during Apply  
+  optional string attributes doesn't accept *empty* value  
+* **resource/junos_snmp_v3_vacm_securitytogroup**: resource now use new [terraform-plugin-framework](https://github.com/hashicorp/terraform-plugin-framework)  
+  some of config errors are now sent during Plan instead of during Apply  
+* **resource/junos_snmp_view**: resource now use new [terraform-plugin-framework](https://github.com/hashicorp/terraform-plugin-framework)  
+* **resource/junos_system**:
+  * add `accounting` block argument (Fix [#630](https://github.com/jeremmfr/terraform-provider-junos/issues/630))
+  * add `radius_options_attributes_nas_id` argument
+  * add `tacplus_options_authorization_time_interval`, `tacplus_options_enhanced_accounting`, `tacplus_options_exclude_cmd_attribute`, `tacplus_options_no_cmd_attribute_value`, `tacplus_options_service_name`, `tacplus_options_strict_authorization`, `tacplus_options_no_strict_authorization`, `tacplus_options_timestamp_and_timezone` arguments
+* **resource/junos_system_radius_server**: resource now use new [terraform-plugin-framework](https://github.com/hashicorp/terraform-plugin-framework)  
+  optional string attributes doesn't accept *empty* value  
+* release now with golang 1.22
+
 ## v2.5.0 (2024-01-25)
 
 FEATURES:

README.md

@@ -30,7 +30,7 @@ for provider and resources documentation.
 
 ### In addition to develop
 
-- [Go](https://golang.org/doc/install) `v1.20` or `v1.21`
+- [Go](https://golang.org/doc/install) `v1.21` or `v1.22`
 
 ## Automatic install
 

docs/data-sources/application_sets.md

@@ -30,7 +30,7 @@ The following arguments are supported:
   List of application-sets to apply a filter on application-sets.  
   The list needs to be exact to match.
 
-## Attributes Reference
+## Attribute Reference
 
 The following attributes are exported:
 

docs/data-sources/applications.md

@@ -59,7 +59,7 @@ The following arguments are supported:
   - **uuid** (Optional, String)  
     Match universal unique identifier for DCE RPC objects.
 
-## Attributes Reference
+## Attribute Reference
 
 The following attributes are exported:
 

docs/data-sources/chassis_inventory.md

@@ -16,7 +16,7 @@ output "SN" {
 }
 ```
 
-## Attributes Reference
+## Attribute Reference
 
 The following attributes are exported:
 

docs/data-sources/interface_logical.md

@@ -32,7 +32,7 @@ The following arguments are supported:
 
 ~> **NOTE:** If more or less than a single match is returned by the search, Terraform will fail.
 
-## Attributes Reference
+## Attribute Reference
 
 The following attributes are exported:
 

docs/data-sources/interface_logical_info.md

@@ -25,7 +25,7 @@ The following arguments are supported:
 - **name** (Required, String)  
   Name of unit interface (with dot).
 
-## Attributes Reference
+## Attribute Reference
 
 The following attributes are exported:
 

docs/data-sources/interface_physical.md

@@ -28,7 +28,7 @@ The following arguments are supported:
 
 ~> **NOTE:** If more or less than a single match is returned by the search, Terraform will fail.
 
-## Attributes Reference
+## Attribute Reference
 
 The following attributes are exported:
 

docs/data-sources/interfaces_physical_present.md

@@ -28,7 +28,7 @@ The following arguments are supported:
 - **match_oper_up** (Optional, Bool)  
   Filter on interfaces that have operational status `up`.
 
-## Attributes Reference
+## Attribute Reference
 
 The following attributes are exported:
 

docs/data-sources/routes.md

@@ -23,7 +23,7 @@ The following arguments are supported:
 - **table_name** (Optional, String)  
   Get routes only on a specific routing table with the name.
 
-## Attributes Reference
+## Attribute Reference
 
 The following attributes are exported:
 

docs/data-sources/routing_instance.md

@@ -22,7 +22,7 @@ The following arguments are supported:
 - **name** (Required, String)  
   The name of routing instance.
 
-## Attributes Reference
+## Attribute Reference
 
 The following attributes are exported:
 

docs/data-sources/security_zone.md

@@ -22,7 +22,7 @@ The following arguments are supported:
 - **name** (Required, String)  
   The name of security zone.
 
-## Attributes Reference
+## Attribute Reference
 
 The following attributes are exported:
 

docs/data-sources/system_information.md

@@ -12,7 +12,7 @@ Get information of the Junos device system information.
 data "junos_system_information" "example" {}
 ```
 
-## Attributes Reference
+## Attribute Reference
 
 The following attributes are exported:
 

docs/resources/access_address_assignment_pool.md

@@ -224,7 +224,7 @@ The following arguments are supported:
   WINS name servers.  
   Need to be valid IPv4 addresses.
 
-## Attributes Reference
+## Attribute Reference
 
 The following attributes are exported:
 

docs/resources/aggregate_route.md

@@ -57,7 +57,7 @@ The following arguments are supported:
 - **preference** (Optional, Number)  
   Preference for aggregate route.
 
-## Attributes Reference
+## Attribute Reference
 
 The following attributes are exported:
 

docs/resources/application.md

@@ -85,7 +85,7 @@ The following arguments are supported:
 - **uuid** (Optional, String)  
   Match universal unique identifier for DCE RPC objects.
 
-## Attributes Reference
+## Attribute Reference
 
 The following attributes are exported:
 

docs/resources/application_set.md

@@ -29,7 +29,7 @@ The following arguments are supported:
 - **description** (Optional, String)  
   Description for application-set.
 
-## Attributes Reference
+## Attribute Reference
 
 The following attributes are exported:
 

docs/resources/bgp_group.md

@@ -234,7 +234,7 @@ Also for `family_inet6` and `family_evpn` (except `nlri_type`)
 - **prefix_limit** (Optional, Block)  
   Same options as `accepted_prefix_limit` but for limit maximum number of prefixes from a peer.
 
-## Attributes Reference
+## Attribute Reference
 
 The following attributes are exported:
 

docs/resources/bgp_neighbor.md

@@ -233,7 +233,7 @@ Also for `family_inet6` and `family_evpn` (except `nlri_type`)
 - **prefix_limit** (Optional, Block)  
   Same options as `accepted_prefix_limit` but for limit maximum number of prefixes from a peer.
 
-## Attributes Reference
+## Attribute Reference
 
 The following attributes are exported:
 

docs/resources/bridge_domain.md

@@ -70,7 +70,7 @@ The following arguments are supported:
   - **vni_extend_evpn** (Optional, Boolean)  
     Extend VNI to EVPN.
 
-## Attributes Reference
+## Attribute Reference
 
 The following attributes are exported:
 

docs/resources/chassis_cluster.md

@@ -105,7 +105,7 @@ The following arguments are supported:
 - **weight** (Required, Number)  
   Weight assigned to this interface that influences failover (0..255).
 
-## Attributes Reference
+## Attribute Reference
 
 The following attributes are exported:
 

docs/resources/chassis_redundancy.md

@@ -44,7 +44,7 @@ The following arguments are supported:
     Define role.  
     Need to be `backup`, `disabled` or `master`.
 
-## Attributes Reference
+## Attribute Reference
 
 The following attributes are exported: