Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsg --fix should only write if the file needs changes #1407

Closed
JennToo opened this issue Mar 3, 2025 · 3 comments · Fixed by #1408
Closed

vsg --fix should only write if the file needs changes #1407

JennToo opened this issue Mar 3, 2025 · 3 comments · Fixed by #1408
Assignees

Comments

@JennToo
Copy link

JennToo commented Mar 3, 2025

Is your feature request related to a problem? Please describe.
I'm using make-style logic in my project. Specifically, there's only a need to re-run analysis / elaboration / simulation if the underlying VHDL files changed.

However, if I just run a blanket vsg --fix all-my-files.vhd, the file timestamps will be touched even if there is nothing to do.

Describe the solution you'd like
Either with a new flag, or just with a change to the default behavior, running vsg --fix ... should only update the file timestamps if something changed.

Describe alternatives you've considered
I've also considered a hack, which is to copy all the files to a temporary directory and then run vsg --fix on them and only copy them back if they've really changed. And this can work as a workaround for sure.

I only file this issue because I suspect others will run into similar situations.

Additional context
N / A

@jeremiah-c-leary
Copy link
Owner

Morning @JennToo ,

I pushed an update for this issue to the issue-1407 branch. When you get a chance could you check it out on your end and let me know if it works for you?

Thanks,

--Jeremy

@jeremiah-c-leary jeremiah-c-leary moved this from In Progress to User Validation in vhdl-style-guide Mar 7, 2025
@JennToo
Copy link
Author

JennToo commented Mar 8, 2025

I gave it a try and it works great! Thanks for the quick fix @jeremiah-c-leary , and thanks for the project overall it has been very helpful 💖

@jeremiah-c-leary
Copy link
Owner

Morning @JennToo ,

Thanks for the kind words.

I will get this merged to master.

Regards,

--Jeremy

@github-project-automation github-project-automation bot moved this from User Validation to Done in vhdl-style-guide Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants