Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): add comment to skip check and test and build for Draft PRs because often times they’re unfinished #669

Merged
merged 2 commits into from
Jan 20, 2024
Merged

chore(ci): add comment to skip check and test and build for Draft PRs because often times they’re unfinished #669

merged 2 commits into from
Jan 20, 2024

Conversation

jenstroeger
Copy link
Owner

No description provided.

@jenstroeger jenstroeger requested a review from behnazh as a code owner December 25, 2023 05:52
behnazh
behnazh requested changes Jan 20, 2024
View reviewed changes
.github/workflows/_build.yaml Outdated Show resolved Hide resolved
@behnazh
Copy link
Collaborator

behnazh commented Jan 20, 2024 •
edited
Loading

I'm not sure if this is a feat PR? 🤔

@jenstroeger
Copy link
Owner Author

I'm not sure if this is a fix PR? 🤔

Are you suggesting to turn the feat(ci) into a fix(ci) here? What problem would it fix, though?

@behnazh
Copy link
Collaborator

behnazh commented Jan 20, 2024

I'm not sure if this is a fix PR? 🤔

Are you suggesting to turn the feat(ci) into a fix(ci) here? What problem would it fix, though?

I meant feat, not fix.

@jenstroeger jenstroeger changed the title feat(ci): don’t check and test and build Draft PRs because often times they’re unfinished chore(ci): add comment to skip check and test and build for Draft PRs because often times they’re unfinished Jan 20, 2024
@jenstroeger jenstroeger requested a review from behnazh January 20, 2024 08:30
@jenstroeger jenstroeger merged commit 59378e1 into staging Jan 20, 2024
10 checks passed
@jenstroeger jenstroeger deleted the dont-build-draft-prs branch September 4, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behnazh behnazh behnazh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jenstroeger @behnazh