From 7ef25319947acd63a138cae7a49d77caaa48e95f Mon Sep 17 00:00:00 2001 From: Jon Jensen Date: Thu, 7 Feb 2019 23:23:56 -0700 Subject: [PATCH] Update appraisals/gemfiles, add contributing notes --- Appraisals | 35 ++++++++++-------------------- README.md | 18 ++++++++++++++- gemfiles/activerecord_5.0.gemfile | 4 ++-- gemfiles/activerecord_5.1.gemfile | 8 +++---- gemfiles/activerecord_5.2.gemfile | 8 +++---- gemfiles/activerecord_edge.gemfile | 8 +++---- 6 files changed, 43 insertions(+), 38 deletions(-) diff --git a/Appraisals b/Appraisals index 591a977..e380862 100644 --- a/Appraisals +++ b/Appraisals @@ -1,31 +1,20 @@ -appraise "activerecord-3.2" do - gem "activerecord", "~> 3.2.0" - gem "mysql", "~> 2.8" - gem "mysql2", "~> 0.3.10" - gem 'pg', '~> 0.11' - gem "sqlite3", "~> 1.3.5" -end - -appraise "activerecord-4.0" do - gem "activerecord", "~> 4.0.0" - gem "mysql", "~> 2.8" - gem "mysql2", "~> 0.3.10" - gem 'pg', '~> 0.11' +appraise "activerecord-5.0" do + gem "activerecord", "~> 5.0.0" + gem "mysql2", "~> 0.4.10" + gem "pg", ">= 0.18", "< 2.0" gem "sqlite3", "~> 1.3.6" - end -appraise "activerecord-4.2" do - gem "activerecord", "~> 4.2.0" - gem 'mysql', '~> 2.9' - gem 'mysql2', '>= 0.3.13', '< 0.5' - gem 'pg', '~> 0.15' +appraise "activerecord-5.1" do + gem "activerecord", "~> 5.1.0" + gem "mysql2", "~> 0.4.10" + gem "pg", ">= 0.18", "< 2.0" gem "sqlite3", "~> 1.3.6" end -appraise "activerecord-5.0" do - gem "activerecord", "~> 5.0.0" - gem "mysql2", "~> 0.4.4" +appraise "activerecord-5.2" do + gem "activerecord", "~> 5.2.0" + gem "mysql2", "~> 0.4.10" gem "pg", ">= 0.18", "< 2.0" gem "sqlite3", "~> 1.3.6" end @@ -33,7 +22,7 @@ end appraise "activerecord-edge" do gem "arel", github: "rails/arel" gem "activerecord", github: "rails/rails" - gem "mysql2", "~> 0.3.11" + gem "mysql2", "~> 0.4.10" gem "pg", ">= 0.18", "< 2.0" gem "sqlite3", "~> 1.3.6" end diff --git a/README.md b/README.md index e85d9bd..7d9f44a 100644 --- a/README.md +++ b/README.md @@ -320,6 +320,22 @@ existing trigger if you wish to redefine it. * Manual `create_trigger` statements have some gotchas. See the section "Manual triggers and :compatibility" +## Contributing + +Contributions welcome! I don't write much Ruby these days 😢 (and haven't used this +gem in years 😬) but am happy to take contributions. If I'm slow to respond, don't +hesitate to @ me repeatedly, sometimes those github notifications slip through +the cracks. 😆. + +If you want to add a feature/bugfix, you can rely on Travis to run the tests, but +do also run them locally (especially if you are changing supported railses/etc). +HairTrigger uses [appraisal](https://github.com/thoughtbot/appraisal) to manage all +that w/ automagical gemfiles. So the tl;dr when testing locally is: + +1. make sure you have mysql and postgres installed (homebrew or whatever) +2. `bundle exec appraisal install` -- get all the dependencies +3. `bundle exec appraisal rake` -- run the specs every which way + ## Compatibility * Ruby 2.3.0+ @@ -332,4 +348,4 @@ existing trigger if you wish to redefine it. ## Copyright -Copyright (c) 2011-2018 Jon Jensen. See LICENSE.txt for further details. +Copyright (c) 2011-2019 Jon Jensen. See LICENSE.txt for further details. diff --git a/gemfiles/activerecord_5.0.gemfile b/gemfiles/activerecord_5.0.gemfile index e0ce2c9..b528423 100644 --- a/gemfiles/activerecord_5.0.gemfile +++ b/gemfiles/activerecord_5.0.gemfile @@ -3,7 +3,7 @@ source "https://rubygems.org" gem "activerecord", "~> 5.0.0" -gem "mysql2", "~> 0.4.4" +gem "mysql2", "~> 0.4.10" gem "pg", ">= 0.18", "< 2.0" gem "sqlite3", "~> 1.3.6" @@ -17,4 +17,4 @@ group :test do gem "rspec", "~> 2.14.0" end -gemspec path: "../" +gemspec :path => "../" diff --git a/gemfiles/activerecord_5.1.gemfile b/gemfiles/activerecord_5.1.gemfile index 88055d6..766457f 100644 --- a/gemfiles/activerecord_5.1.gemfile +++ b/gemfiles/activerecord_5.1.gemfile @@ -3,7 +3,9 @@ source "https://rubygems.org" gem "activerecord", "~> 5.1.0" -gem "mysql2", "~> 0.4.4" +gem "mysql2", "~> 0.4.10" +gem "pg", ">= 0.18", "< 2.0" +gem "sqlite3", "~> 1.3.6" group :development do gem "appraisal" @@ -13,8 +15,6 @@ end group :test do gem "rake", "~> 10.0" gem "rspec", "~> 2.14.0" - gem "pg", ">= 0.18", "< 2.0" - gem "sqlite3", "~> 1.3.6" end -gemspec path: "../" +gemspec :path => "../" diff --git a/gemfiles/activerecord_5.2.gemfile b/gemfiles/activerecord_5.2.gemfile index 8a0a7b3..8e1c56b 100644 --- a/gemfiles/activerecord_5.2.gemfile +++ b/gemfiles/activerecord_5.2.gemfile @@ -3,7 +3,9 @@ source "https://rubygems.org" gem "activerecord", "~> 5.2.0" -gem "mysql2", "~> 0.4.4" +gem "mysql2", "~> 0.4.10" +gem "pg", ">= 0.18", "< 2.0" +gem "sqlite3", "~> 1.3.6" group :development do gem "appraisal" @@ -13,8 +15,6 @@ end group :test do gem "rake", "~> 10.0" gem "rspec", "~> 2.14.0" - gem "pg", ">= 0.18", "< 2.0" - gem "sqlite3", "~> 1.3.6" end -gemspec path: "../" +gemspec :path => "../" diff --git a/gemfiles/activerecord_edge.gemfile b/gemfiles/activerecord_edge.gemfile index fd6a1bc..99644b1 100644 --- a/gemfiles/activerecord_edge.gemfile +++ b/gemfiles/activerecord_edge.gemfile @@ -2,9 +2,9 @@ source "https://rubygems.org" -gem "arel", github: "rails/arel" -gem "activerecord", github: "rails/rails" -gem "mysql2", "~> 0.3.11" +gem "arel", :github => "rails/arel" +gem "activerecord", :github => "rails/rails" +gem "mysql2", "~> 0.4.10" gem "pg", ">= 0.18", "< 2.0" gem "sqlite3", "~> 1.3.6" @@ -18,4 +18,4 @@ group :test do gem "rspec", "~> 2.14.0" end -gemspec path: "../" +gemspec :path => "../"