Skip to content

Commit

Permalink
Update appraisals/gemfiles, add contributing notes
Browse files Browse the repository at this point in the history
  • Loading branch information
jenseng committed Feb 8, 2019
1 parent 3e82999 commit 7ef2531
Show file tree
Hide file tree
Showing 6 changed files with 43 additions and 38 deletions.
35 changes: 12 additions & 23 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,39 +1,28 @@
appraise "activerecord-3.2" do
gem "activerecord", "~> 3.2.0"
gem "mysql", "~> 2.8"
gem "mysql2", "~> 0.3.10"
gem 'pg', '~> 0.11'
gem "sqlite3", "~> 1.3.5"
end

appraise "activerecord-4.0" do
gem "activerecord", "~> 4.0.0"
gem "mysql", "~> 2.8"
gem "mysql2", "~> 0.3.10"
gem 'pg', '~> 0.11'
appraise "activerecord-5.0" do
gem "activerecord", "~> 5.0.0"
gem "mysql2", "~> 0.4.10"
gem "pg", ">= 0.18", "< 2.0"
gem "sqlite3", "~> 1.3.6"

end

appraise "activerecord-4.2" do
gem "activerecord", "~> 4.2.0"
gem 'mysql', '~> 2.9'
gem 'mysql2', '>= 0.3.13', '< 0.5'
gem 'pg', '~> 0.15'
appraise "activerecord-5.1" do
gem "activerecord", "~> 5.1.0"
gem "mysql2", "~> 0.4.10"
gem "pg", ">= 0.18", "< 2.0"
gem "sqlite3", "~> 1.3.6"
end

appraise "activerecord-5.0" do
gem "activerecord", "~> 5.0.0"
gem "mysql2", "~> 0.4.4"
appraise "activerecord-5.2" do
gem "activerecord", "~> 5.2.0"
gem "mysql2", "~> 0.4.10"
gem "pg", ">= 0.18", "< 2.0"
gem "sqlite3", "~> 1.3.6"
end

appraise "activerecord-edge" do
gem "arel", github: "rails/arel"
gem "activerecord", github: "rails/rails"
gem "mysql2", "~> 0.3.11"
gem "mysql2", "~> 0.4.10"
gem "pg", ">= 0.18", "< 2.0"
gem "sqlite3", "~> 1.3.6"
end
18 changes: 17 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,22 @@ existing trigger if you wish to redefine it.
* Manual `create_trigger` statements have some gotchas. See the section
"Manual triggers and :compatibility"

## Contributing

Contributions welcome! I don't write much Ruby these days 😢 (and haven't used this
gem in years 😬) but am happy to take contributions. If I'm slow to respond, don't
hesitate to @ me repeatedly, sometimes those github notifications slip through
the cracks. 😆.

If you want to add a feature/bugfix, you can rely on Travis to run the tests, but
do also run them locally (especially if you are changing supported railses/etc).
HairTrigger uses [appraisal](https://github.com/thoughtbot/appraisal) to manage all
that w/ automagical gemfiles. So the tl;dr when testing locally is:

1. make sure you have mysql and postgres installed (homebrew or whatever)
2. `bundle exec appraisal install` -- get all the dependencies
3. `bundle exec appraisal rake` -- run the specs every which way

## Compatibility

* Ruby 2.3.0+
Expand All @@ -332,4 +348,4 @@ existing trigger if you wish to redefine it.

## Copyright

Copyright (c) 2011-2018 Jon Jensen. See LICENSE.txt for further details.
Copyright (c) 2011-2019 Jon Jensen. See LICENSE.txt for further details.
4 changes: 2 additions & 2 deletions gemfiles/activerecord_5.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
source "https://rubygems.org"

gem "activerecord", "~> 5.0.0"
gem "mysql2", "~> 0.4.4"
gem "mysql2", "~> 0.4.10"
gem "pg", ">= 0.18", "< 2.0"
gem "sqlite3", "~> 1.3.6"

Expand All @@ -17,4 +17,4 @@ group :test do
gem "rspec", "~> 2.14.0"
end

gemspec path: "../"
gemspec :path => "../"
8 changes: 4 additions & 4 deletions gemfiles/activerecord_5.1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
source "https://rubygems.org"

gem "activerecord", "~> 5.1.0"
gem "mysql2", "~> 0.4.4"
gem "mysql2", "~> 0.4.10"
gem "pg", ">= 0.18", "< 2.0"
gem "sqlite3", "~> 1.3.6"

group :development do
gem "appraisal"
Expand All @@ -13,8 +15,6 @@ end
group :test do
gem "rake", "~> 10.0"
gem "rspec", "~> 2.14.0"
gem "pg", ">= 0.18", "< 2.0"
gem "sqlite3", "~> 1.3.6"
end

gemspec path: "../"
gemspec :path => "../"
8 changes: 4 additions & 4 deletions gemfiles/activerecord_5.2.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
source "https://rubygems.org"

gem "activerecord", "~> 5.2.0"
gem "mysql2", "~> 0.4.4"
gem "mysql2", "~> 0.4.10"
gem "pg", ">= 0.18", "< 2.0"
gem "sqlite3", "~> 1.3.6"

group :development do
gem "appraisal"
Expand All @@ -13,8 +15,6 @@ end
group :test do
gem "rake", "~> 10.0"
gem "rspec", "~> 2.14.0"
gem "pg", ">= 0.18", "< 2.0"
gem "sqlite3", "~> 1.3.6"
end

gemspec path: "../"
gemspec :path => "../"
8 changes: 4 additions & 4 deletions gemfiles/activerecord_edge.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

source "https://rubygems.org"

gem "arel", github: "rails/arel"
gem "activerecord", github: "rails/rails"
gem "mysql2", "~> 0.3.11"
gem "arel", :github => "rails/arel"
gem "activerecord", :github => "rails/rails"
gem "mysql2", "~> 0.4.10"
gem "pg", ">= 0.18", "< 2.0"
gem "sqlite3", "~> 1.3.6"

Expand All @@ -18,4 +18,4 @@ group :test do
gem "rspec", "~> 2.14.0"
end

gemspec path: "../"
gemspec :path => "../"

0 comments on commit 7ef2531

Please sign in to comment.