fix: Removed GSON jar dependency and added plugin dependency #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. I am not planning to change the Jenkins baseline right now. I will revive this PR when the baseline has been moved… |
jonesbusy
reviewed
Jan 11, 2024
| @@ -51,6 +51,7 @@ | |||
| <argLine>-Djava.awt.headless=true -Xmx1024m -Djenkins.test.timeout=1000 --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.util.concurrent=ALL-UNNAMED</argLine> | |||
|
|
|||
| <prism-api.version>1.29.0-8</prism-api.version> | |||
| <jenkins.version>2.414.1</jenkins.version> | |||
There was a problem hiding this comment.
gson-api need minimum 2.401.3. Not 2.414.1
There was a problem hiding this comment.
I had done tried both the comments.
In this case, I get the error:
[ERROR] Failed to execute goal org.jenkins-ci.tools:maven-hpi-plugin:3.50:validate-hpi (default-validate-hpi) on project warnings-ng: Dependency io.jenkins:configuration-as-code:jar:1714.v09593e830cfa requires Jenkins 2.414.1 or higher.
jonesbusy
reviewed
Jan 11, 2024
| <version>2.10.1</version> | ||
| <groupId>io.jenkins.plugins</groupId> | ||
| <artifactId>gson-api</artifactId> | ||
| <version>2.10.1-15.v0d99f670e0a_7</version> |
There was a problem hiding this comment.
Don't include version if part of bom
There was a problem hiding this comment.
If I remove the version I get the following error:
[ERROR] The project io.jenkins.plugins:warnings-ng:10.7.0-SNAPSHOT (C:\Users\tiwar\open-source\warnings-ng-plugin\plugin\pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for io.jenkins.plugins:gson-api:jar is missing. @ io.jenkins.plugins:warnings-ng:${revision}${changelist},
There was a problem hiding this comment.
So use a bom version that include gson-api. Is part of bom since something like 1 month
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing done
Submitter checklist
Added the plugin dependency GSON library as mentioned in the issue.
Closes
#JENKINS-72494