Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-71435] Make empty properties clickable #1648

Merged
merged 4 commits into from
Jan 4, 2024
Merged

[JENKINS-71435] Make empty properties clickable #1648

merged 4 commits into from
Jan 4, 2024

Conversation

debayangg
Copy link
Contributor

@debayangg debayangg commented Dec 29, 2023

Fixes JENKINS-71435. Changed formatProperty() method in DetailsTableModel.java to display issues with blank categories as '-' category.

Before change:
Before

After change:
After

Testing done

Tests Passed

Submitter checklist

Preview Give feedback

@debayangg debayangg changed the title [JENKINS-71435] Unknown category unusable in Java Compiler Warnings [JENKINS-71435] Resolved unusable categories in Java Compiler Warnings Dec 29, 2023
@debayangg debayangg changed the title [JENKINS-71435] Resolved unusable categories in Java Compiler Warnings [JENKINS-71435] Resolved unusable categories in Issues view Dec 29, 2023
@uhafner uhafner added the enhancement Enhancement of existing functionality label Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (018c572) 81.82% compared to head (759fd66) 81.83%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1648      +/-   ##
============================================
+ Coverage     81.82%   81.83%   +0.01%     
  Complexity     1411     1411              
============================================
  Files           249      249              
  Lines          5358     5361       +3     
  Branches        398      399       +1     
============================================
+ Hits           4384     4387       +3     
  Misses          861      861              
  Partials        113      113              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner changed the title [JENKINS-71435] Resolved unusable categories in Issues view [JENKINS-71435] Make empty properties clickable Dec 29, 2023
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also add a small unit test in DetailsTableModelTest?

@debayangg
Copy link
Contributor Author

I will be travelling for a few days so it might take a bit of time to add the unit tests.

@debayangg debayangg requested a review from uhafner January 3, 2024 07:07
@uhafner uhafner merged commit 2a3c046 into jenkinsci:main Jan 4, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants