Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove suppress warnings: ctor rule has been disabled globally #1631

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Remove suppress warnings: ctor rule has been disabled globally #1631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>org.jvnet.hudson.plugins</groupId>
<artifactId>analysis-pom</artifactId>
<version>6.15.0</version>
<version>6.16.0</version>
<relativePath />
</parent>

Expand Down
1 change: 0 additions & 1 deletion plugin/src/main/java/io/jenkins/plugins/analysis/core/steps/PublishIssuesStep.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -854,7 +854,6 @@ static class Execution extends AnalysisExecution<ResultAction> {
* the actual step to execute
*/
@SuppressWarnings("PMD.AvoidLiteralsInIfCondition")
@SuppressFBWarnings(value = "CT_CONSTRUCTOR_THROW", justification = "Fail fast if no reports are provided")
Execution(@NonNull final StepContext context, final PublishIssuesStep step) {
super(context);

Expand Down
2 changes: 0 additions & 2 deletions plugin/src/main/java/io/jenkins/plugins/analysis/warnings/RegisteredParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import edu.hm.hafner.analysis.registry.ParserRegistry;
import edu.hm.hafner.util.VisibleForTesting;
import edu.umd.cs.findbugs.annotations.NonNull;
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;

import org.kohsuke.stapler.DataBoundConstructor;
import org.kohsuke.stapler.verb.POST;
Expand Down Expand Up @@ -45,7 +44,6 @@ public class RegisteredParser extends ReportScanningTool {
* the unique ID of the tool in the analysis-model module
*/
@DataBoundConstructor
@SuppressFBWarnings(value = "CT_CONSTRUCTOR_THROW", justification = "Fail fast if parser is not found")
public RegisteredParser(final String analysisModelId) {
super();

Expand Down
2 changes: 0 additions & 2 deletions plugin/src/main/java/io/jenkins/plugins/analysis/warnings/RevApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import edu.hm.hafner.analysis.Issue;
import edu.hm.hafner.analysis.Report;
import edu.hm.hafner.analysis.RevApiInfoExtension;
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;

import org.kohsuke.stapler.DataBoundConstructor;
import org.jenkinsci.Symbol;
Expand Down Expand Up @@ -151,7 +150,6 @@ public static class RevApiRow extends TableRow {
private final String severity;
private String category;

@SuppressFBWarnings(value = "CT_CONSTRUCTOR_THROW", justification = "Fail fast if wrong type has been passed")
RevApiRow(final AgeBuilder ageBuilder, final FileNameRenderer fileNameRenderer,
final DescriptionProvider descriptionProvider, final Issue issue,
final JenkinsFacade jenkinsFacade, final Serializable additionalData) {
Expand Down
Loading