[JENKINS-72317] Use Jenkins.READ permission check for all list box models #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, use permissions for a `BuildableItem` in all validations.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -281,9 +280,9 @@ | |||
| * @return the validation result | |||
| */ | |||
| @POST | |||
| public FormValidation doCheckReportEncoding(@AncestorInPath final AbstractProject<?, ?> project, | |||
| public FormValidation doCheckReportEncoding(@AncestorInPath final BuildableItem project, | |||
Check notice
Code scanning / CodeQL
Useless parameter
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1621 +/- ##
============================================
- Coverage 81.80% 81.72% -0.08%
- Complexity 1407 1409 +2
============================================
Files 249 249
Lines 5353 5357 +4
Branches 397 397
============================================
- Hits 4379 4378 -1
- Misses 856 865 +9
+ Partials 118 114 -4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, use permissions for a
BuildableItemin all validations.See https://issues.jenkins.io/browse/JENKINS-72317 for details.