Add an integer-based threshold for quality gates.

jenkinsci · Jan 4, 2024 · d1f0abe · d1f0abe
1 parent 7c345c7
commit d1f0abe
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/plugin/src/main/java/io/jenkins/plugins/analysis/core/util/WarningsQualityGate.java b/plugin/src/main/java/io/jenkins/plugins/analysis/core/util/WarningsQualityGate.java
@@ -65,6 +65,11 @@ public WarningsQualityGate(final int threshold, final QualityGateType type,
         setCriticality(criticality);
     }
 
+    public boolean isUnstable() {
+        return getCriticality() == QualityGateCriticality.UNSTABLE
+                || getCriticality() == QualityGateCriticality.NOTE;
+    }
+
     /**
      * Sets the criticality of the quality gate.
      *

diff --git a/ui-tests/src/test/java/io/jenkins/plugins/analysis/warnings/SnippetGeneratorUiTest.java b/ui-tests/src/test/java/io/jenkins/plugins/analysis/warnings/SnippetGeneratorUiTest.java
@@ -130,7 +130,7 @@ public void shouldHandleComplexConfiguration() {
         assertThat(script).contains("filters: [excludeType('*toExclude*')]");
         assertThat(script).contains("ignoreFailedBuilds: false");
         assertThat(script).contains("ignoreQualityGate: true");
-        assertThat(script).contains("qualityGates: [[threshold: 1, type: 'NEW', criticality: 'FAILURE']]");
+        assertThat(script).contains("qualityGates: [[integerThreshold: 1, type: 'NEW', criticality: 'FAILURE']]");
 
         assertThat(script).contains("pattern: 'firstText'");
         assertThat(script).contains("sourceCodeEncoding: 'otherText'");