Fix test failures.

jenkinsci · Jan 15, 2025 · c6d8a80 · c6d8a80
1 parent e65548a
commit c6d8a80
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/plugin/src/main/java/io/jenkins/plugins/analysis/core/model/IconLabelProvider.java b/plugin/src/main/java/io/jenkins/plugins/analysis/core/model/IconLabelProvider.java
@@ -11,6 +11,18 @@ public class IconLabelProvider extends StaticAnalysisLabelProvider {
     private final String smallIconUrl;
     private final String largeIconUrl;
 
+    /**
+     * Creates a new label provider with the specified ID and name.
+     *
+     * @param id
+     *         the ID (i.e., URL)
+     * @param name
+     *         the name of the tool
+     */
+    public IconLabelProvider(final String id, final String name) {
+        this(id, name, EMPTY_DESCRIPTION);
+    }
+
     /**
      * Creates a new label provider with the specified ID and name.
      *

diff --git a/plugin/src/test/java/io/jenkins/plugins/analysis/warnings/integrations/JobDslITest.java b/plugin/src/test/java/io/jenkins/plugins/analysis/warnings/integrations/JobDslITest.java
@@ -69,7 +69,7 @@ void shouldCreateFreestyleJobUsingJobDslAndVerifyIssueRecorderWithDefaultConfigu
         assertThat(project).isNotNull();
         assertThat(project).isInstanceOf(FreeStyleProject.class);
 
-        DescribableList<Publisher, Descriptor<Publisher>> publishers = ((FreeStyleProject) project).getPublishersList();
+        var publishers = ((FreeStyleProject) project).getPublishersList();
         assertThat(publishers).hasSize(1);
 
         Publisher publisher = publishers.get(0);
@@ -85,10 +85,11 @@ void shouldCreateFreestyleJobUsingJobDslAndVerifyIssueRecorderWithDefaultConfigu
         assertThat(recorder.getBlameDisabled()).isFalse();
         assertThat(recorder.getEnabledForFailure()).isFalse();
         assertThat(recorder.getHealthy()).isEqualTo(0);
-        assertThat(recorder.getId()).isNull();
+        assertThat(recorder.getId()).isEmpty();
+        assertThat(recorder.getIcon()).isEmpty();
         assertThat(recorder.getIgnoreQualityGate()).isFalse();
         assertThat(recorder.getMinimumSeverity()).isEqualTo("LOW");
-        assertThat(recorder.getName()).isNull();
+        assertThat(recorder.getName()).isEmpty();
         assertThat(recorder.getQualityGates()).hasSize(0);
         assertThat(recorder.getSourceCodeEncoding()).isEmpty();
         assertThat(recorder.getUnhealthy()).isEqualTo(0);