Replace empty property with "-".

Otherwise the hyperlink is not clickable.
jenkinsci · Mar 6, 2024 · 9e6bb4a · 9e6bb4a
1 parent 63180f5
commit 9e6bb4a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/plugin/src/main/java/io/jenkins/plugins/analysis/core/model/PropertyStatistics.java b/plugin/src/main/java/io/jenkins/plugins/analysis/core/model/PropertyStatistics.java
@@ -83,7 +83,7 @@ public String getProperty() {
      * @return the display name
      */
     public String getDisplayName(final String key) {
-        return propertyFormatter.apply(key);
+        return StringUtils.defaultIfBlank(propertyFormatter.apply(key), "-");
     }
 
     /**

diff --git a/plugin/src/test/java/io/jenkins/plugins/analysis/core/model/PropertyStatisticsTest.java b/plugin/src/test/java/io/jenkins/plugins/analysis/core/model/PropertyStatisticsTest.java
@@ -21,7 +21,7 @@ class PropertyStatisticsTest {
     private static final String KEY = "key";
 
     /**
-     * Verifies that getTotal() returns the total number of issues if there is one issues.
+     * Verifies that getTotal() returns the total number of issues if there is one issue.
      */
     @Test
     void shouldReturnTotalNumber() {
@@ -37,7 +37,7 @@ void shouldReturnTotalNumber() {
     }
 
     /**
-     * Verifies that getTotal() returns the total number of issues if there is one issues.
+     * Verifies that getTotal() returns the total number of issues if there is one issue.
      */
     @Test
     void shouldReturnTotalNumberMoreIssues() {
@@ -136,7 +136,7 @@ void shouldReturnAllKeys() {
     }
 
     /**
-     * Verifies that getKeys() returns empty string if the instances for this property is empty.
+     * Verifies that getKeys() returns "-" string if the instances for this property are empty.
      */
     @Test
     void shouldReturnEmptyStringKeys() {
@@ -147,7 +147,7 @@ void shouldReturnEmptyStringKeys() {
             PropertyStatistics statistics = new PropertyStatistics(issues, new Report(), "category",
                     Function.identity());
 
-            assertThat(statistics).hasOnlyKeys("");
+            assertThat(statistics).hasOnlyKeys("-");
         }
     }
 
@@ -178,7 +178,7 @@ void shouldReturnMaxValueZero() {
     }
 
     /**
-     * Verifies that getMax() returns one if there is one issues.
+     * Verifies that getMax() returns one if there is one issue.
      */
     @Test
     void shouldReturnMaxValue() {
@@ -245,7 +245,7 @@ void shouldReturnCountEmpty() {
     }
 
     /**
-     * Verifies that getCount() returns one if there is one issues for the specified property instance.
+     * Verifies that getCount() returns one if there is one issue for the specified property instance.
      */
     @Test
     void shouldReturnCountOne() {
@@ -546,7 +546,7 @@ void shouldReturnNewCountOne() {
     }
 
     /**
-     * Verifies that getNewCount() returns  zero if there is one issues for the specified property instance, but it isn't new.
+     * Verifies that getNewCount() returns  zero if there is one issue for the specified property instance, but it isn't new.
      */
     @Test
     void shouldReturnNewCountZero() {