Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default branch name #1601

Closed
wants to merge 1 commit into from
Closed

Change the default branch name #1601

wants to merge 1 commit into from

Conversation

rtyler
Copy link
Member

@rtyler rtyler commented Jun 25, 2024

Most branches created in recent history use main to denote the primary branch. This value is used in the snippet generator, so important to have correct IMHO

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • Documentation in README has been updated as necessary
  • Online help has been added and reviewed for any new or modified fields
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. Delete the items in the list that do not apply

  • Dependency or infrastructure update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Most branches created in recent history use `main` to denote the primary branch. This value is used in the snippet generator, so important to have correct IMHO
@rtyler rtyler requested a review from a team as a code owner June 25, 2024 18:26
@MarkEWaite
Copy link
Contributor

Thanks for the pull request @rtyler. Unfortunately, many more changes are needed before we can adjust the default branch name in the Pipeline step to use main instead of master. If you're interested in doing those changes, they would include:

  • Update tests to adapt to the new default branch name
  • Update documentation to describe the new default branch name
  • Perform compatibility tests to confirm the new default branch name does not break existing users that are still using master as the primary branch name

@rtyler
Copy link
Member Author

rtyler commented Jul 1, 2024

@MarkEWaite thanks! unfortunately I'm not interested in this time investment 😄 I respectfully withdraw from the field 😄

@rtyler rtyler closed this Jul 1, 2024
@MarkEWaite MarkEWaite deleted the rtyler-patch-1 branch July 15, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants