Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table resizing #386

Merged
merged 3 commits into from
Jan 6, 2025
Merged

table resizing #386

merged 3 commits into from
Jan 6, 2025

Conversation

mawinter69
Copy link
Contributor

make the table sample resizable
add icons to table

image

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

make the table sample resizable
@mawinter69 mawinter69 requested a review from a team as a code owner January 6, 2025 01:48
@@ -0,0 +1,3 @@
.jenkins-icon-size {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.jenkins prefix shouldn't be used in the design library, its jdl

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this even used though?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The t:iconsSize internally uses this class and has a larger bottom margin. As the jdl-component-sample has a large padding those two would lead to bigger gap in the UI between table and sample code:
Without that it looks like this
image

With margin removed:
image

Found a way to avoid using it

avoid using jenkins-icon-size class
@timja timja added the developer label Jan 6, 2025
@timja timja merged commit 5601ba3 into jenkinsci:master Jan 6, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants