stay compatible for PCT (#2552)

jenkinsci · Aug 27, 2024 · aa8c31d · aa8c31d
1 parent 3ad2056
commit aa8c31d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/plugin/src/main/java/io/jenkins/plugins/casc/ConfigurationAsCode.java b/plugin/src/main/java/io/jenkins/plugins/casc/ConfigurationAsCode.java
@@ -265,9 +265,9 @@ private boolean canApplyFrom(List<YamlSource> yamlSources) {
 
     @POST
     @Restricted(NoExternalUse.class)
-    public FormValidation doCheckNewSource(@QueryParameter String value) {
+    public FormValidation doCheckNewSource(@QueryParameter String newSource) {
         Jenkins.get().checkPermission(Jenkins.ADMINISTER);
-        String normalizedSource = Util.fixEmptyAndTrim(value);
+        String normalizedSource = Util.fixEmptyAndTrim(newSource);
         if (normalizedSource == null) {
             return FormValidation.ok(); // empty, do nothing
         }

diff --git a/plugin/src/main/resources/io/jenkins/plugins/casc/ConfigurationAsCode/index.jelly b/plugin/src/main/resources/io/jenkins/plugins/casc/ConfigurationAsCode/index.jelly
@@ -26,7 +26,7 @@
       <f:form method="post" action="replace" name="replace">
           <h2>${%Replace configuration source with:}</h2>
           <f:entry title="${%Path or URL}" field="newSource" >
-              <f:textbox checkUrl="checkNewSource" checkDependsOn=""/>
+              <f:textbox checkUrl="checkNewSource" checkDependsOn="newSource"/>
           </f:entry>
           <f:block>
             <f:submit name="replace" value="${%Apply new configuration}"/>

diff --git a/test-harness/src/main/java/io/jenkins/plugins/casc/misc/RoundTripAbstractTest.java b/test-harness/src/main/java/io/jenkins/plugins/casc/misc/RoundTripAbstractTest.java
@@ -159,7 +159,7 @@ private void assertConfigViaWebUI(String jenkinsConfig) throws Exception {
         // Call the check url
         JenkinsRule.WebClient client = r.j.createWebClient();
         WebRequest request = new WebRequest(client.createCrumbedUrl("configuration-as-code/checkNewSource"), POST);
-        NameValuePair param = new NameValuePair("value", f.toURI().toURL().toExternalForm());
+        NameValuePair param = new NameValuePair("newSource", f.toURI().toURL().toExternalForm());
         request.setRequestParameters(Collections.singletonList(param));
         WebResponse response = client.loadWebResponse(request);
         assertEquals("Failed to POST to " + request.getUrl().toString(), 200, response.getStatusCode());