Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-70153] Add support for gradle build-tools warnings (w:) #1145

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

code-arnab
Copy link
Contributor

Testing done

Closes

Added support for gradle build-tools warnings (w:) by modifying the Pattern in the JavacParser. Now it matches the filename/line format along with quoted messages as mentioned in the issue.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@code-arnab
Copy link
Contributor Author

Hello @uhafner I closed the earlier PR. Since, the local history became a mess (maybe I messed up during rebase). So, I cloned again, synced everything but the build is still failing.

@uhafner uhafner added the enhancement Enhancement of existing functionality label Feb 19, 2025
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I don't understand why ci.jenkins.io is picking version 11.x as baseline and not 13.0.0.

At least GitHub is not complaining anymore. So we are good to go! 🚀

@code-arnab
Copy link
Contributor Author

That's a relief! Thank you for all the help

@uhafner
Copy link
Member

uhafner commented Feb 19, 2025

FTR: I created jenkins-infra/helpdesk#4543

@uhafner uhafner merged commit 8546567 into jenkinsci:main Feb 19, 2025
16 of 19 checks passed
@code-arnab
Copy link
Contributor Author

Thank you!

@uhafner uhafner changed the title [Jenkins-70153] Add support for gradle build-tools warnings (w:) [JENKINS-70153] Add support for gradle build-tools warnings (w:) Feb 19, 2025
@uhafner
Copy link
Member

uhafner commented Feb 19, 2025

Thanks for your PR, released as https://github.com/jenkinsci/analysis-model/releases/tag/v13.1.0.

@code-arnab
Copy link
Contributor Author

That's great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants