Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jenkins-70153] Add support for gradle build-tools warnings (w:) #1142

Closed
wants to merge 4 commits into from

Conversation

code-arnab
Copy link
Contributor

Testing done

Closes

Added support for gradle build-tools warnings (w:) by modifying the Pattern in the JavacParser. Now it matches the filename/line format along with quoted messages as mentioned in the issue.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@code-arnab
Copy link
Contributor Author

Hello @uhafner can you please review this PR, all the tests have passed but got this error in 'bat' step during the build.
Thank You

@MarkEWaite
Copy link
Contributor

Hello @uhafner can you please review this PR, all the tests have passed but got this error in 'bat' step during the build. Thank You

The failure is because all pull requests in this repository must be labeled by a maintainer. That's not something that a contributor can do.

@code-arnab
Copy link
Contributor Author

Ah I see! That makes sense.
Thank you for the clarification

@uhafner uhafner added the bug Bugs or performance problems label Feb 17, 2025
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost perfect. Just improve the assertions so we are sure that the properties are mapped correctly.

@uhafner
Copy link
Member

uhafner commented Feb 17, 2025

You can ignore the other build failure as I am currently preparing a new major release...

@code-arnab
Copy link
Contributor Author

You can ignore the other build failure as I am currently preparing a new major release...

Understood! Thanks for the clarification

@uhafner
Copy link
Member

uhafner commented Feb 17, 2025

I just released 13.0.0. Can you please rebase the main branch? Then the error hopefully should disappear.

@code-arnab
Copy link
Contributor Author

I just released 13.0.0. Can you please rebase the main branch? Then the error hopefully should disappear.

Great! I've just added all the other assertions will be committing the changes soon.

@code-arnab
Copy link
Contributor Author

Hello @uhafner it is now failing with " You have 1 Checkstyle violation".

@uhafner
Copy link
Member

uhafner commented Feb 18, 2025

There is still a tab in your code:

[INFO] --- checkstyle:3.6.0:check (run-checkstyle-java) @ analysis-model ---
[WARNING] src/main/java/edu/hm/hafner/analysis/parser/JavacParser.java:[47,42] (whitespace) FileTabCharacter: File contains tab characters (this is the first instance).
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE

@code-arnab
Copy link
Contributor Author

Hello @uhafner there are no checkstyle errors this time but the Jenkins build again failed error in 'bat' step even after the log saying no checkstyle errors and Fork value is true.

I'm not quite sure about this error -
[WARNING] Difference transform org.revapi.basic.VersionsTransform@257e9d0 of class 'class org.revapi.basic.VersionsTransform' threw an exception while processing difference Difference[code='java.missing.oldClass', name='class missing in old API archives', classification={BINARY=POTENTIALLY_BREAKING, SOURCE=POTENTIALLY_BREAKING}, description='Class 'edu.hm.hafner.util.FilteredLog' could not be found in the archives of the old API. It has been detected as contributing to the API and thus the analysis results may be incorrect.', justification='null', criticality=null, attachments={classSimpleName=FilteredLog, package=edu.hm.hafner.util, classQualifiedName=edu.hm.hafner.util.FilteredLog, exampleUseChainInOldApi=edu.hm.hafner.util.FilteredLog is used as parameter in method void edu.hm.hafner.analysis.Report::mergeLogMessages(edu.hm.hafner.util.FilteredLog) (method void edu.hm.hafner.analysis.Report::mergeLogMessages(edu.hm.hafner.util.FilteredLog) is part of the API), elementKind=class}] on old element missing-class edu.hm.hafner.util.FilteredLog and new element null

@uhafner
Copy link
Member

uhafner commented Feb 18, 2025

It seems that you did not yet rebase to the new main branch. This is required, otherwise revapi will not compare to the latest 13.0.0 release.

@code-arnab code-arnab closed this by deleting the head repository Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants