-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jenkins-70153] Add support for gradle build-tools warnings (w:) #1142
Conversation
Hello @uhafner can you please review this PR, all the tests have passed but got this |
The failure is because all pull requests in this repository must be labeled by a maintainer. That's not something that a contributor can do. |
Ah I see! That makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks almost perfect. Just improve the assertions so we are sure that the properties are mapped correctly.
You can ignore the other build failure as I am currently preparing a new major release... |
Understood! Thanks for the clarification |
I just released 13.0.0. Can you please rebase the main branch? Then the error hopefully should disappear. |
Great! I've just added all the other assertions will be committing the changes soon. |
Hello @uhafner it is now failing with " You have 1 Checkstyle violation". |
There is still a tab in your code:
|
Hello @uhafner there are no checkstyle errors this time but the Jenkins build again failed I'm not quite sure about this error - |
It seems that you did not yet rebase to the new |
06a1992
to
76ac339
Compare
cfdb493
to
6792fb1
Compare
Testing done
Closes
Added support for gradle build-tools warnings (w:) by modifying the Pattern in the
JavacParser
. Now it matches the filename/line format along with quoted messages as mentioned in the issue.Submitter checklist