Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon and logo support #400

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Icon and logo support #400

wants to merge 5 commits into from

Conversation

Jmuccigr
Copy link

@Jmuccigr Jmuccigr commented Dec 30, 2023

A patch to support a blog icon and logo via the _config.yml file. Many feed readers will default to using a site's favicon or icon resources, but the Atom spec supports both an icon (square, so with 1:1 proportions) and a logo (2:1 proportions), so this adds them in. I did this with a more generalizable addition to the xml file:

blog:
  icon: path/image.png
  logo: path/image2.png

In theory other blog properties could be added here, like a blog title (which I already have set up).

If there's a blog_icon defined in the _config.yml file, then this will insert it as an icon into the Atom feed. (Many readers don't support this, but some do.)
@Jmuccigr Jmuccigr mentioned this pull request Dec 30, 2023
Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely game for this. It needs a test though. The reader I use, NetNewsWire, seems to offer pulling in the favicon but having a custom icon could be neat.

This was helpful for my understanding of these two fields: https://stackoverflow.com/a/29953980

README.md Outdated Show resolved Hide resolved
@Jmuccigr
Copy link
Author

Jmuccigr commented Jan 3, 2024

Definitely game for this. It needs a test though. The reader I use, NetNewsWire, seems to offer pulling in the favicon but having a custom icon could be neat.

This was helpful for my understanding of these two fields: https://stackoverflow.com/a/29953980

Yeah, NetNewsWire is my reader too, and it doesn’t support this yet. Working on that, too. :-)

Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this just needs a simple test then we're good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants