Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a record of all checks in a PR #62

Open
ashmaroli opened this issue Jul 30, 2018 · 3 comments
Open

Have a record of all checks in a PR #62

ashmaroli opened this issue Jul 30, 2018 · 3 comments

Comments

@ashmaroli
Copy link
Member

This is to allow atomic comparison of the impact of the proposed changes of a PR in [WIP] mode.

Scenario: Examine impact of all proposed commits on performance
  Given that I have a WIP pull request with multiple individually pushed commits
  And that those commits encompass meaningful and significant changes
  When I examine the "report page" url for a commit
  Then I should be able to inspect the report page of any "previous commit" from the current page
  And I should be able to inspect the report page of any "following commit" from the current page

The benefit from this is that contributors will have easier insight on the course of their final proposal. For example, if a WIP-PR has 5 individually pushed commits with 3 commits that improve performance and the following 2 that slightly lower performance, the author would have to currently either:

  • open 5 individual tabs (to report page) to closely examine the report of each commit
  • or traverse back and forth on the currently open tab

Related requirements:

  • change current :details_url from /:sha.html to /:owner/:repo/:pull_id/:sha.html
@pathawks
Copy link
Member

You are saying the generated HTML report for every commit should include a link to the parent commit and and child commits?

@ashmaroli
Copy link
Member Author

You are saying the generated HTML report for every commit should include a link to the parent commit and and child commits?

More or less, yes. But mainly just a tab for all checks run in given PR..

@pathawks
Copy link
Member

This is currently impossible in the generated HTML. Since each checkrun is atomic, there is no knowledge of past or future commits in the PR.
What we could maybe do is have GitHub keep a check run for each commit in the Checks tab, instead of overwriting the last Performance Check when a new one is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants