Skip to content

Commit

Permalink
Lint all JSON files, update pre-commit steps
Browse files Browse the repository at this point in the history
  • Loading branch information
jefflester committed Nov 21, 2024
1 parent aa409a2 commit a7cad0e
Show file tree
Hide file tree
Showing 40 changed files with 241 additions and 205 deletions.
17 changes: 16 additions & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,31 @@ repos:
rev: 24.10.0
hooks:
- id: black
always_run: true

- repo: local
hooks:
- id: jq-format
name: Format JSON with jq
entry: bash -c 'tmpfile=$(mktemp) && jq . "$1" > "$tmpfile" && mv "$tmpfile" "$1"'
entry: |-
bash -c '
for file in $(find . -name "*.json" ! -path "./.vscode/*"); do
echo "Processing $file"
tmpfile=$(mktemp)
if ! jq . "$file" > "$tmpfile"; then
echo "Failed to process $file"
exit 1
fi
mv "$tmpfile" "$file"
done
'
language: system
files: \.json$
always_run: true
pass_filenames: false

- repo: https://github.com/adrienverge/yamllint
rev: v1.35.1
hooks:
- id: yamllint
always_run: true
2 changes: 1 addition & 1 deletion .yamllint
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
extends: default

rules:
line-length:
line-length: # Compose volume mounts cannot be wrapped
level: warning
8 changes: 6 additions & 2 deletions src/lib/modules/admin/cache-service/metadata.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
{
"description": "Cache service module (enables materialized view management and table scan redirections)",
"incompatibleModules": [],
"dependentModules": ["hive", "postgres", "insights"],
"dependentModules": [
"hive",
"postgres",
"insights"
],
"enterprise": true
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@
]
}
]
}
}
5 changes: 4 additions & 1 deletion src/lib/modules/admin/data-products/metadata.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
{
"description": "Data products module",
"incompatibleModules": [],
"dependentModules": ["insights", "hive"],
"dependentModules": [
"insights",
"hive"
],
"enterprise": true
}
11 changes: 5 additions & 6 deletions src/lib/modules/admin/file-group-provider/metadata.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"description": "File group provider module",
"incompatibleModules": [],
"dependentModules": [],
"enterprise": false
}

"description": "File group provider module",
"incompatibleModules": [],
"dependentModules": [],
"enterprise": false
}
5 changes: 4 additions & 1 deletion src/lib/modules/admin/session-property-manager/metadata.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
{
"description": "Session property manager module",
"incompatibleModules": [],
"dependentModules": ["file-group-provider", "resource-groups"],
"dependentModules": [
"file-group-provider",
"resource-groups"
],
"enterprise": false
}
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@
"query_max_execution_time": "1h"
}
}
]
]
8 changes: 4 additions & 4 deletions src/lib/modules/catalog/clickhouse/metadata.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"description": "ClickHouse catalog module",
"incompatibleModules": [],
"enterprise": false
}
"description": "ClickHouse catalog module",
"incompatibleModules": [],
"enterprise": false
}
8 changes: 4 additions & 4 deletions src/lib/modules/catalog/db2/metadata.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"description": "Db2 catalog module",
"incompatibleModules": [],
"enterprise": true
}
"description": "Db2 catalog module",
"incompatibleModules": [],
"enterprise": true
}
8 changes: 4 additions & 4 deletions src/lib/modules/catalog/delta-lake/metadata.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"description": "Delta Lake catalog module (includes object storage (MinIO) and Hive metastore)",
"incompatibleModules": [],
"enterprise": false
}
"description": "Delta Lake catalog module (includes object storage (MinIO) and Hive metastore)",
"incompatibleModules": [],
"enterprise": false
}
8 changes: 4 additions & 4 deletions src/lib/modules/catalog/elasticsearch/metadata.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"description": "Elasticsearch catalog module",
"incompatibleModules": [],
"enterprise": false
}
"description": "Elasticsearch catalog module",
"incompatibleModules": [],
"enterprise": false
}
8 changes: 4 additions & 4 deletions src/lib/modules/catalog/hive/metadata.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"description": "Hive catalog module (includes object storage (MinIO) and Hive metastore)",
"incompatibleModules": [],
"enterprise": false
}
"description": "Hive catalog module (includes object storage (MinIO) and Hive metastore)",
"incompatibleModules": [],
"enterprise": false
}
8 changes: 4 additions & 4 deletions src/lib/modules/catalog/iceberg/metadata.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"description": "Iceberg catalog module (uses Iceberg REST catalog for metadata management)",
"incompatibleModules": [],
"enterprise": false
}
"description": "Iceberg catalog module (uses Iceberg REST catalog for metadata management)",
"incompatibleModules": [],
"enterprise": false
}
8 changes: 4 additions & 4 deletions src/lib/modules/catalog/mariadb/metadata.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"description": "MariaDB catalog module",
"incompatibleModules": [],
"enterprise": false
}
"description": "MariaDB catalog module",
"incompatibleModules": [],
"enterprise": false
}
8 changes: 4 additions & 4 deletions src/lib/modules/catalog/mysql/metadata.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"description": "MySQL catalog module",
"incompatibleModules": [],
"enterprise": false
}
"description": "MySQL catalog module",
"incompatibleModules": [],
"enterprise": false
}
8 changes: 4 additions & 4 deletions src/lib/modules/catalog/pinot/metadata.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"description": "Pinot catalog module",
"incompatibleModules": [],
"enterprise": false
}
"description": "Pinot catalog module",
"incompatibleModules": [],
"enterprise": false
}
6 changes: 3 additions & 3 deletions src/lib/modules/catalog/sqlserver/metadata.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"description": "SQL Server catalog module",
"incompatibleModules": [],
"enterprise": false
"description": "SQL Server catalog module",
"incompatibleModules": [],
"enterprise": false
}
14 changes: 9 additions & 5 deletions src/lib/modules/catalog/test/metadata.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
{
"description": "Test module.",
"incompatibleModules": ["ldap"],
"dependentModules": ["file-access-control"],
"versions": [],
"enterprise": false
"description": "Test module.",
"incompatibleModules": [
"ldap"
],
"dependentModules": [
"file-access-control"
],
"versions": [],
"enterprise": false
}
4 changes: 3 additions & 1 deletion src/lib/modules/security/biac/metadata.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{
"description": "Built-in access control (BIAC) module",
"incompatibleModules": [],
"dependentModules": ["insights"],
"dependentModules": [
"insights"
],
"enterprise": true
}
14 changes: 9 additions & 5 deletions src/lib/modules/security/file-access-control/metadata.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
{
"description": "File-based access control module",
"incompatibleModules": ["biac"],
"dependentModules": ["file-group-provider"],
"enterprise": false
}
"description": "File-based access control module",
"incompatibleModules": [
"biac"
],
"dependentModules": [
"file-group-provider"
],
"enterprise": false
}
Loading

0 comments on commit a7cad0e

Please sign in to comment.