Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: triangle mesh #12

Merged
merged 11 commits into from
Dec 22, 2023
Merged

fix: triangle mesh #12

merged 11 commits into from
Dec 22, 2023

Conversation

jeertmans
Copy link
Owner

No description provided.

Copy link
Contributor

github-actions bot commented Dec 21, 2023

Python benchmark results:


Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

Copy link
Contributor

github-actions bot commented Dec 21, 2023

Rust benchmark results:

 name                                         before ns/iter  changes ns/iter  diff ns/iter  diff %  speedup 
 bench_rt_utils_generate_all_path_candidates  7,036,002       7,179,447             143,445   2.04%   x 0.98 
 bench_rt_utils_where_true                    1,744,292       1,824,454              80,162   4.60%   x 0.96 

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (5bc7da1) 44.00% compared to head (f27168f) 76.80%.

Files Patch % Lines
python/differt/geometry/triangle_mesh.py 71.42% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #12       +/-   ##
===========================================
+ Coverage   44.00%   76.80%   +32.80%     
===========================================
  Files           9       10        +1     
  Lines         175      194       +19     
===========================================
+ Hits           77      149       +72     
+ Misses         98       45       -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeertmans jeertmans merged commit 6330732 into main Dec 22, 2023
23 of 31 checks passed
@jeertmans jeertmans deleted the fix-triangle-mesh branch December 22, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant