From 222e67dd16d59ef6ee87ef156e5a06c15764abd4 Mon Sep 17 00:00:00 2001
From: Jean Carlo Machado <jean.machado@getyourguide.com>
Date: Sun, 16 Jun 2024 21:37:20 +0200
Subject: [PATCH] improvements

---
 python_search/entry_runner.py                 |  6 +--
 python_search/privacy/__init__.py             |  0
 python_search/privacy/privacy_detector.py     | 40 -------------------
 python_search/search/entries_loader.py        | 12 ------
 python_search/search/search_ui/kitty.py       |  2 +-
 python_search/search/search_ui/terminal_ui.py |  5 +--
 6 files changed, 5 insertions(+), 60 deletions(-)
 delete mode 100644 python_search/privacy/__init__.py
 delete mode 100644 python_search/privacy/privacy_detector.py

diff --git a/python_search/entry_runner.py b/python_search/entry_runner.py
index 02f5f0b4..e880328f 100644
--- a/python_search/entry_runner.py
+++ b/python_search/entry_runner.py
@@ -1,5 +1,4 @@
 from __future__ import annotations
-
 import re
 import os
 from typing import List
@@ -10,9 +9,8 @@
 from python_search.interpreter.interpreter_matcher import InterpreterMatcher
 from python_search.logger import setup_run_key_logger
 from python_search.error.exception import notify_exception
-from python_search.search.search_ui.serialized_entry import (
-    decode_serialized_data_from_entry_text,
-)
+from python_search.search.search_ui.serialized_entry import decode_serialized_data_from_entry_text
+
 
 
 class EntryRunner:
diff --git a/python_search/privacy/__init__.py b/python_search/privacy/__init__.py
deleted file mode 100644
index e69de29b..00000000
diff --git a/python_search/privacy/privacy_detector.py b/python_search/privacy/privacy_detector.py
deleted file mode 100644
index 3533ec23..00000000
--- a/python_search/privacy/privacy_detector.py
+++ /dev/null
@@ -1,40 +0,0 @@
-from typing import List, Tuple
-
-
-class PrivacyDetector:
-    def __init__(self):
-        from python_search.configuration.loader import ConfigurationLoader
-
-        self.configuration = ConfigurationLoader().load_config()
-
-    def has_sentitive_content(self, the_string) -> bool:
-        return self.get_sensitive_content(the_string)[0]
-
-    def get_sensitive_content(self, the_string) -> Tuple[bool, str]:
-        for term in self.configuration.privacy_sensitive_terms:
-            if term in the_string:
-                return True, term
-        return False, None
-
-    def detect_in_list(self, data: List[str]):
-        sensitive_entries = 0
-        total_entries = 0
-        for entry in data:
-            is_sensitive, term = self.get_sensitive_content(entry)
-            if is_sensitive:
-                print(f"Found {term} in string: {entry[0:100]}")
-                sensitive_entries += 1
-            total_entries += 1
-        print(
-            "Found ",
-            sensitive_entries,
-            " sensitive entries in a total of ",
-            total_entries,
-            " entries",
-        )
-
-
-if __name__ == "__main__":
-    import fire
-
-    fire.Fire(PrivacyDetector)
diff --git a/python_search/search/entries_loader.py b/python_search/search/entries_loader.py
index 123d6d65..0b9d6e8c 100644
--- a/python_search/search/entries_loader.py
+++ b/python_search/search/entries_loader.py
@@ -30,18 +30,6 @@ def load_entries_as_json(self):
 
         return json.dumps(result)
 
-    @staticmethod
-    def load_privacy_neutral_only() -> List[Entry]:
-        from python_search.privacy.privacy_detector import PrivacyDetector
-
-        detector = PrivacyDetector()
-
-        for i in EntriesLoader.load_all_entries():
-            if not detector.has_sentitive_content(
-                i.get_content_str()
-            ) and not detector.has_sentitive_content(i.key):
-                yield i
-
     @staticmethod
     def load_all_entries() -> List[Entry]:
         """
diff --git a/python_search/search/search_ui/kitty.py b/python_search/search/search_ui/kitty.py
index 64f42cd1..36afc1b2 100644
--- a/python_search/search/search_ui/kitty.py
+++ b/python_search/search/search_ui/kitty.py
@@ -11,7 +11,7 @@ class KittySearch:
     Renders the search ui using fzf + termite terminal
     """
 
-    _DEFAULT_WINDOW_SIZE = (990, 170)
+    _DEFAULT_WINDOW_SIZE = (800, 170)
 
     _configuration = None
 
diff --git a/python_search/search/search_ui/terminal_ui.py b/python_search/search/search_ui/terminal_ui.py
index ce82b204..f044801c 100644
--- a/python_search/search/search_ui/terminal_ui.py
+++ b/python_search/search/search_ui/terminal_ui.py
@@ -14,9 +14,8 @@
 
 
 class SearchTerminalUi:
-    MAX_LINE_SIZE = 80
-    MAX_KEY_SIZE = 45
-    MAX_CONTENT_SIZE = 45
+    MAX_KEY_SIZE = 35
+    MAX_CONTENT_SIZE = 35
     NUMBER_ENTRIES_TO_RETURN = 6
 
     _documents_future = None