Merge pull request #272 from jdi-testing/issue_265

fix equal locators generation
jdi-testing · Aug 2, 2021 · d8fa525 · d8fa525
2 parents 9746545 + 191b45b
commit d8fa525
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/manifest.json b/manifest.json
@@ -3,7 +3,7 @@
   "name": "JDN",
   "description": "",
   "devtools_page": "index.html",
-  "version": "3.0.32",
+  "version": "3.0.33",
   "permissions": [
     "activeTab",
     "tabs",

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "jdi-react-extension",
-  "version": "3.0.32",
+  "version": "3.0.33",
   "description": "jdi react extension",
   "scripts": {
     "start": "npm run webpack",

diff --git a/src/js/blocks/autoFind/autoFindProvider/pageObject.js b/src/js/blocks/autoFind/autoFindProvider/pageObject.js
@@ -27,13 +27,13 @@ export const predictedToConvert = (elements) => {
     let elementName = getElementName(e);
     let elementTagId = e.predictedAttrId;
 
-    if (uniqueNames.indexOf(elementName) > 0) elementName += i;
-    if (elementTagId && uniqueNames.indexOf(elementTagId) > 0) elementTagId += i;
+    if (uniqueNames.indexOf(elementName) >= 0) elementName += i;
+    if (elementTagId && uniqueNames.indexOf(elementTagId) >= 0) elementTagId += i;
     uniqueNames.push(elementTagId, elementName);
 
     return {
       ...e,
-      Locator: e.attrId ? `#${e.attrId}` : e.xpath,
+      Locator: e.xpath,
       Name: elementTagId ? elementTagId : elementName,
       Type: getJDILabel(e.predicted_label),
       parent: null,