Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4949-refactoringCheckBoxTests #5084

Merged
merged 15 commits into from
Nov 8, 2023
Merged

4949-refactoringCheckBoxTests #5084

merged 15 commits into from
Nov 8, 2023

Conversation

MayaElf
Copy link
Contributor

@MayaElf MayaElf commented Sep 26, 2023

No description provided.

@MayaElf MayaElf self-assigned this Sep 26, 2023
@MayaElf MayaElf linked an issue Sep 26, 2023 that may be closed by this pull request
Tests refactoring: checkbox element #4949
Closed
8 tasks
@vklonin vklonin self-requested a review October 4, 2023 07:07
@MayaElf MayaElf force-pushed the 4949_checkBoxTestsRefactoring branch from 02258c2 to 46b353e Compare October 11, 2023 11:05
pnatashap
pnatashap requested changes Oct 12, 2023
View reviewed changes
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/Checkbox.java Outdated Show resolved Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/Checkbox.java Outdated Show resolved Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/Checkbox.java Outdated Show resolved Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/Checkbox.java Outdated Show resolved Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/Checkbox.java Outdated Show resolved Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/Checkbox.java Outdated Show resolved Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/asserts/CheckboxAssert.java Outdated Show resolved Hide resolved
...-angular-tests/src/test/java/io/github/epam/angular/tests/elements/common/CheckboxTests.java Outdated Show resolved Hide resolved
...-angular-tests/src/test/java/io/github/epam/angular/tests/elements/common/CheckboxTests.java Outdated Show resolved Hide resolved
@MayaElf MayaElf changed the title 4949-refactoringCheckBoxTests [WIP]4949-refactoringCheckBoxTests Oct 13, 2023
@MayaElf MayaElf requested a review from pnatashap October 18, 2023 08:46
@MayaElf MayaElf changed the title [WIP]4949-refactoringCheckBoxTests 4949-refactoringCheckBoxTests Oct 18, 2023
pnatashap
pnatashap requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@pnatashap pnatashap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the control was checked

jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/Checkbox.java Outdated Show resolved Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/Checkbox.java Outdated Show resolved Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/Checkbox.java Outdated Show resolved Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/Checkbox.java Outdated Show resolved Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/Checkbox.java Outdated Show resolved Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/Checkbox.java Show resolved Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/Checkbox.java Outdated Show resolved Hide resolved
@MayaElf MayaElf requested a review from pnatashap October 24, 2023 11:41
pnatashap
pnatashap requested changes Oct 24, 2023
View reviewed changes
jdi-light-angular-tests/src/main/java/io/github/com/pages/CheckBoxPage.java Outdated Show resolved Hide resolved
...-angular-tests/src/test/java/io/github/epam/angular/tests/elements/common/CheckboxTests.java Outdated Show resolved Hide resolved
...-angular-tests/src/test/java/io/github/epam/angular/tests/elements/common/CheckboxTests.java Show resolved Hide resolved
...-angular-tests/src/test/java/io/github/epam/angular/tests/elements/common/CheckboxTests.java Show resolved Hide resolved
...-angular-tests/src/test/java/io/github/epam/angular/tests/elements/common/CheckboxTests.java Outdated Show resolved Hide resolved
...-angular-tests/src/test/java/io/github/epam/angular/tests/elements/common/CheckboxTests.java Show resolved Hide resolved
...-angular-tests/src/test/java/io/github/epam/angular/tests/elements/common/CheckboxTests.java Outdated Show resolved Hide resolved
...-angular-tests/src/test/java/io/github/epam/angular/tests/elements/common/CheckboxTests.java Outdated Show resolved Hide resolved
@MayaElf MayaElf requested a review from pnatashap October 25, 2023 13:52
pnatashap
pnatashap requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@pnatashap pnatashap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Появление CheckBoxMode в angular проекте

jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/enums/CheckBoxModes.java Outdated Show resolved Hide resolved
@MayaElf MayaElf requested a review from pnatashap October 26, 2023 08:57
@MayaElf MayaElf force-pushed the 4949_checkBoxTestsRefactoring branch from 4cdfa79 to 643a72e Compare October 26, 2023 09:00
@MayaElf MayaElf force-pushed the 4949_checkBoxTestsRefactoring branch from 643a72e to e7b1f5d Compare October 26, 2023 09:03
@MayaElf MayaElf changed the title 4949-refactoringCheckBoxTests [WIP]4949-refactoringCheckBoxTests Oct 31, 2023
@MayaElf MayaElf changed the title [WIP]4949-refactoringCheckBoxTests 4949-refactoringCheckBoxTests Nov 1, 2023
@MayaElf MayaElf requested a review from pnatashap November 1, 2023 14:21
@MayaElf MayaElf requested a review from pnatashap November 3, 2023 10:23
@MayaElf MayaElf requested a review from pnatashap November 6, 2023 15:23
@MayaElf MayaElf requested a review from pnatashap November 7, 2023 13:16
@vklonin vklonin merged commit 65f0bea into angular_rework_development Nov 8, 2023
7 checks passed
@vklonin vklonin deleted the 4949_checkBoxTestsRefactoring branch November 8, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vklonin vklonin vklonin approved these changes

@pnatashap pnatashap pnatashap approved these changes

Assignees

@MayaElf MayaElf

Labels
Angular Refactoring code refactoring ReWork
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests refactoring: checkbox element
3 participants
@MayaElf @pnatashap @vklonin